Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write a function to swap out long commands for short ones #9

Open
D4RKONION opened this issue Mar 5, 2021 · 3 comments · May be fixed by #16
Open

Write a function to swap out long commands for short ones #9

D4RKONION opened this issue Mar 5, 2021 · 3 comments · May be fixed by #16
Labels
enhancement New feature or request

Comments

@D4RKONION
Copy link
Owner

e.g. Stand -> st. etc.

This shouldn't be hard at all, and would neatly fit into renameFrameData function in the helpers.js file

@D4RKONION D4RKONION added the enhancement New feature or request label Mar 5, 2021
@jmarkman
Copy link

jmarkman commented Mar 9, 2021

Hey, mind if I take a stab at this? Looks like a good first issue and I'd like to help out where I can.

@D4RKONION
Copy link
Owner Author

Hey! Yeah go for it! Some thoughts, and do jump into the discord to chat more about it!

  • Arrow functions please
  • const where possible
  • .map/.forEach rather than for loops

What I was thinking was the utils/index.js function renameData() would take another variable "Normal Notation" that would be set in the settings menu. Possibly best to iterate over only the normals after line 14 const renamedFrameData = mapKeys... though honestly I wrote that code suuuper early in the FAT rewrite so I'm not sure haha!

Even if you want to just get the function working I can do the settings menu side of things if the ionic stuff in settings.jsx is confusing. Do as much as you want. One of us will also have to make a new redux store entry to track the setting (action, reducer etc.)

Finally, please use the following naming convention

Stand - st.
Crouch - cr.
Jump j.
Neutral Jump - nj.
Forward - f.
Back b.
Down Forward - df.
Down Back - db.

Good luck!

@jmarkman
Copy link

jmarkman commented Mar 9, 2021

I've just joined the discord, I definitely have a few questions. Noted about the JS and move naming conventions.

I'll try to keep the issue updated based on the conversations we have in discord.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants