Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow_module_overrides doesn't work with AsyncBuilder #1216

Closed
rwhitten577 opened this issue Nov 5, 2024 · 1 comment · Fixed by #1217
Closed

allow_module_overrides doesn't work with AsyncBuilder #1216

rwhitten577 opened this issue Nov 5, 2024 · 1 comment · Fixed by #1217
Labels
triage label for issues that need to be triaged.

Comments

@rwhitten577
Copy link
Contributor

Tried using the allow_module_overrides with an AsyncBuilder. It sets the param on the builder, but it does not get passed in when the AsyncDriver (and thus the Driver) is initialized:

  1. https://github.com/DAGWorks-Inc/hamilton/blob/main/hamilton/async_driver.py#L490-L495
  2. https://github.com/DAGWorks-Inc/hamilton/blob/main/hamilton/async_driver.py#L232-L246

I think the arg just needs to be passed down from AsyncBuilder -> AsyncDriver -> Driver.

Example:

builder = (
     AsyncBuilder()
    .with_config(config)
    .with_modules(*self.included_modules)
    .allow_module_overrides()
    .with_adapters(self.result_builder)
)
driver = await builder.build()
@rwhitten577 rwhitten577 added the triage label for issues that need to be triaged. label Nov 5, 2024
@rwhitten577
Copy link
Contributor Author

Working on a PR now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage label for issues that need to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant