adjust initial call / appointment date period to diverge a little bit, for late callers #3264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lomky
approved these changes
Sep 11, 2024
| @@ -247,7 +247,7 @@ def as_json | |||
| private | |||
|
|
|||
| def confirm_appointment_after_initial_call | |||
| if appointment_date.present? && initial_call_date&.send(:>, appointment_date) | |||
| if appointment_date.present? && initial_call_date.present? && (initial_call_date - 60.days)&.send(:>, appointment_date) | |||
| errors.add(:appointment_date, 'must be after date of initial call') | |||
There was a problem hiding this comment.
Suggested change
| errors.add(:appointment_date, 'must be after date of initial call') | |
| errors.add(:appointment_date, 'must be closer to the date of initial call') |
maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rule and have completed some work on Case Manager that's ready for review!
Some of the funds we work with are doing some retroactive pledging; in our data model, this conflicts a bit with a rule we enforce of appointment date being after initial call. This PR loosens that rule with a 60 day window - that felt like the point at which it might become an accident. We'll see if it requires further adjustment.
This pull request makes the following changes:
no view changes
It relates to the following issue #s:
For reviewer:
featureif it contains a feature, fix, or similar. This is anything that contains a user-facing fix in some way, such as frontend changes, alterations to backend behavior, or bug fixes.dependenciesif it contains library upgrades or similar. This is anything that upgrades any dependency, such as a Gemfile update or npm package upgrade.