From b1aa59246fc1e40390a9a01aefa19d62124d5436 Mon Sep 17 00:00:00 2001
From: Cole Blanchard <33158416+blanchco@users.noreply.github.com>
Date: Mon, 25 Nov 2024 14:53:20 -0500
Subject: [PATCH] remove feature config where applicable (#5620)

Co-authored-by: Cole Blanchard <cblanchard@Coles-MacBook-Pro.local>
---
 .../src/components/asset/tera-asset.vue       | 26 ++-----------------
 .../components/dataset/tera-column-info.vue   | 19 ++------------
 .../src/components/dataset/tera-dataset.vue   | 13 +---------
 .../llm/tera-beaker-code-cell-output.vue      |  6 ++---
 .../model/petrinet/tera-model-description.vue |  4 +--
 .../src/components/model/tera-model.vue       | 23 ++++------------
 .../tera-dataset-transformer-node.vue         |  1 -
 7 files changed, 13 insertions(+), 79 deletions(-)

diff --git a/packages/client/hmi-client/src/components/asset/tera-asset.vue b/packages/client/hmi-client/src/components/asset/tera-asset.vue
index b430d40b06..fd6f506ca6 100644
--- a/packages/client/hmi-client/src/components/asset/tera-asset.vue
+++ b/packages/client/hmi-client/src/components/asset/tera-asset.vue
@@ -11,14 +11,6 @@
 		<div v-if="overline" class="row">
 			<span class="overline">{{ overline }}</span>
 			<slot name="edit-buttons" />
-			<Button
-				v-if="featureConfig.isPreview"
-				class="close"
-				icon="pi pi-times"
-				rounded
-				text
-				@click="emit('close-preview')"
-			/>
 		</div>
 		<!--For naming asset such as model or code file-->
 		<div class="row">
@@ -27,14 +19,6 @@
 				{{ name }}
 			</h4>
 			<slot v-if="!overline" name="edit-buttons" />
-			<Button
-				v-if="!overline && featureConfig.isPreview"
-				class="close"
-				icon="pi pi-times"
-				rounded
-				text
-				@click="emit('close-preview')"
-			/>
 		</div>
 		<!--put model contributors here too-->
 		<span v-if="authors" class="authors">
@@ -77,10 +61,8 @@
 </template>
 
 <script setup lang="ts">
-import { ref, computed, watch, PropType, useSlots, nextTick } from 'vue';
+import { ref, computed, watch, useSlots, nextTick } from 'vue';
 import { useRoute } from 'vue-router';
-import Button from 'primevue/button';
-import type { FeatureConfig } from '@/types/common';
 import { ProjectPages } from '@/types/Project';
 import { AssetType } from '@/types/Types';
 import TabView from 'primevue/tabview';
@@ -112,10 +94,6 @@ const props = defineProps({
 		type: String,
 		default: null
 	},
-	featureConfig: {
-		type: Object as PropType<FeatureConfig>,
-		default: { isPreview: false } as FeatureConfig
-	},
 	showHeader: {
 		type: Boolean,
 		default: true
@@ -132,7 +110,7 @@ const props = defineProps({
 	}
 });
 
-const emit = defineEmits(['close-preview', 'tab-change']);
+const emit = defineEmits(['tab-change']);
 
 const slots = useSlots();
 const pageType = useRoute().params.pageType as ProjectPages | AssetType;
diff --git a/packages/client/hmi-client/src/components/dataset/tera-column-info.vue b/packages/client/hmi-client/src/components/dataset/tera-column-info.vue
index af30bc2f68..e9121fde44 100644
--- a/packages/client/hmi-client/src/components/dataset/tera-column-info.vue
+++ b/packages/client/hmi-client/src/components/dataset/tera-column-info.vue
@@ -3,18 +3,14 @@
 		<section class="entries">
 			<span class="name">
 				<h6>{{ column.symbol }}</h6>
-				<template v-if="featureConfig.isPreview">{{ column.name }}</template>
 				<tera-input-text
-					v-else
 					placeholder="Add a name"
 					:model-value="column.name ?? ''"
 					@update:model-value="$emit('update-column', { key: 'name', value: $event })"
 				/>
 			</span>
 			<span class="unit">
-				<template v-if="featureConfig.isPreview"><label>Unit</label>{{ column.unit }}</template>
 				<tera-input-text
-					v-else
 					label="Unit"
 					placeholder="Add a unit"
 					:characters-to-reject="[' ']"
@@ -24,20 +20,16 @@
 			</span>
 			<span class="data-type">
 				<label>Data type</label>
-				<template v-if="featureConfig.isPreview">{{ column.dataType }}</template>
 				<Dropdown
-					v-else
 					placeholder="Select a data type"
 					:model-value="column.dataType ?? ''"
 					@update:model-value="$emit('update-column', { key: 'dataType', value: $event })"
 					:options="Object.values(ColumnType)"
 				/>
 			</span>
-			<span v-if="showConcept" class="concept">
+			<span class="concept">
 				<label>Concept</label>
-				<template v-if="featureConfig.isPreview">{{ query }}</template>
 				<AutoComplete
-					v-else
 					size="small"
 					placeholder="Search concepts"
 					v-model="query"
@@ -52,9 +44,7 @@
 				/>
 			</span>
 			<span class="description">
-				<template v-if="featureConfig.isPreview">{{ column.description }}</template>
 				<tera-input-text
-					v-else
 					placeholder="Add a description"
 					:model-value="column.description ?? ''"
 					@update:model-value="$emit('update-column', { key: 'description', value: $event })"
@@ -70,14 +60,13 @@
 
 <script setup lang="ts">
 /* Copied the structure of tera-model-parts.vue */
-import { ref, computed, watch } from 'vue';
+import { ref, watch } from 'vue';
 import TeraInputText from '@/components/widgets/tera-input-text.vue';
 import TeraBoxplot from '@/components/widgets/tera-boxplot.vue';
 import AutoComplete from 'primevue/autocomplete';
 import Dropdown from 'primevue/dropdown';
 import { type DKG, ColumnType, type Grounding } from '@/types/Types';
 import { searchCuriesEntities } from '@/services/concept';
-import type { FeatureConfig } from '@/types/common';
 
 type ColumnInfo = {
 	symbol: string;
@@ -92,7 +81,6 @@ type ColumnInfo = {
 
 const props = defineProps<{
 	column: ColumnInfo;
-	featureConfig: FeatureConfig;
 }>();
 
 const emit = defineEmits(['update-column']);
@@ -100,9 +88,6 @@ const emit = defineEmits(['update-column']);
 const query = ref('');
 const results = ref<DKG[]>([]);
 
-// If we are in preview mode and there is no content, show nothing
-const showConcept = computed(() => !(props.featureConfig.isPreview && !query.value));
-
 // Used if an option isn't selected from the Autocomplete suggestions but is typed in regularly
 function applyValidConcept() {
 	// Allows to empty the concept
diff --git a/packages/client/hmi-client/src/components/dataset/tera-dataset.vue b/packages/client/hmi-client/src/components/dataset/tera-dataset.vue
index a21b2dd0d3..742293e888 100644
--- a/packages/client/hmi-client/src/components/dataset/tera-dataset.vue
+++ b/packages/client/hmi-client/src/components/dataset/tera-dataset.vue
@@ -1,14 +1,12 @@
 <template>
 	<tera-asset
 		show-table-of-contents
-		:feature-config="featureConfig"
 		:id="assetId"
 		:is-loading="isDatasetLoading"
 		:is-naming-asset="isRenaming"
 		:name="dataset?.name"
 		:overflow-hidden="selectedTabIndex === 1"
 		:selected-tab-index="selectedTabIndex"
-		@close-preview="emit('close-preview')"
 		@tab-change="(e) => (selectedTabIndex = e.index)"
 	>
 		<template #name-input>
@@ -22,7 +20,7 @@
 			/>
 			<Button v-if="isRenaming" icon="pi pi-check" rounded text @click="updateDatasetName" />
 		</template>
-		<template #edit-buttons v-if="!featureConfig.isPreview">
+		<template #edit-buttons>
 			<Button
 				icon="pi pi-ellipsis-v"
 				class="p-button-icon-only p-button-text p-button-rounded"
@@ -61,7 +59,6 @@
 					:key="index"
 					class="column-info"
 					:column="column"
-					:feature-config="{ isPreview: false }"
 					@update-column="updateColumn(index, $event.key, $event.value)"
 				/>
 			</AccordionTab>
@@ -86,7 +83,6 @@ import {
 } from '@/services/dataset';
 import { AssetType, type CsvAsset, type Dataset, PresignedURL } from '@/types/Types';
 import TeraAsset from '@/components/asset/tera-asset.vue';
-import type { FeatureConfig } from '@/types/common';
 import { DatasetSource } from '@/types/Dataset';
 import { useProjects } from '@/composables/project';
 import TeraInputText from '@/components/widgets/tera-input-text.vue';
@@ -106,18 +102,12 @@ const props = defineProps({
 		type: String,
 		required: true
 	},
-	featureConfig: {
-		type: Object as PropType<FeatureConfig>,
-		default: { isPreview: false } as FeatureConfig
-	},
 	source: {
 		type: String as PropType<DatasetSource>,
 		default: DatasetSource.TERARIUM
 	}
 });
 
-const emit = defineEmits(['close-preview']);
-
 const currentActiveIndexes = ref([1, 2, 3, 4]);
 const dataset = ref<Dataset | null>(null);
 const transientDataset = ref<Dataset | null>(null);
@@ -151,7 +141,6 @@ const optionsMenuItems = ref<any[]>([
 			if (presignedUrl) {
 				window.open(presignedUrl.url, '_blank');
 			}
-			emit('close-preview');
 		}
 	}
 ]);
diff --git a/packages/client/hmi-client/src/components/llm/tera-beaker-code-cell-output.vue b/packages/client/hmi-client/src/components/llm/tera-beaker-code-cell-output.vue
index b08a5b02cc..16775a128e 100644
--- a/packages/client/hmi-client/src/components/llm/tera-beaker-code-cell-output.vue
+++ b/packages/client/hmi-client/src/components/llm/tera-beaker-code-cell-output.vue
@@ -1,16 +1,14 @@
 <template>
-	<div :class="{ isPreview: featureConfig?.isPreview }" ref="outputAreaRef" />
+	<div class="output-area" ref="outputAreaRef" />
 </template>
 
 <script setup lang="ts">
 import { JupyterMessage, renderMime } from '@/services/jupyter';
 import { computed, onMounted, ref, watch } from 'vue';
 import { OutputArea, OutputAreaModel } from '@jupyterlab/outputarea';
-import { FeatureConfig } from '@/types/common';
 
 const props = defineProps<{
 	jupyterMessage: JupyterMessage;
-	featureConfig?: FeatureConfig;
 }>();
 
 const outputAreaRef = ref<HTMLDivElement | null>(null);
@@ -73,7 +71,7 @@ defineExpose({
 
 <style scoped>
 div {
-	&.isPreview {
+	&.output-area {
 		&:deep(.lm-Widget.p-Widget.jp-OutputPrompt.jp-OutputArea-prompt) {
 			display: none;
 		}
diff --git a/packages/client/hmi-client/src/components/model/petrinet/tera-model-description.vue b/packages/client/hmi-client/src/components/model/petrinet/tera-model-description.vue
index 46f76c897c..f1edeae78e 100644
--- a/packages/client/hmi-client/src/components/model/petrinet/tera-model-description.vue
+++ b/packages/client/hmi-client/src/components/model/petrinet/tera-model-description.vue
@@ -5,7 +5,7 @@
 			<Editor v-else v-model="editorContent" />
 		</AccordionTab>
 		<AccordionTab header="Diagram">
-			<tera-model-diagram :model="model" :mmt-data="mmtData" :feature-config="featureConfig" />
+			<tera-model-diagram :model="model" :mmt-data="mmtData" />
 		</AccordionTab>
 		<AccordionTab header="Model equations">
 			<tera-model-equation :model="model" :is-editable="false" @model-updated="emit('update-model')" />
@@ -29,7 +29,6 @@ import AccordionTab from 'primevue/accordiontab';
 import Column from 'primevue/column';
 import DataTable from 'primevue/datatable';
 import Editor from 'primevue/editor';
-import { FeatureConfig } from '@/types/common';
 import type { Dataset, Model } from '@/types/Types';
 import TeraModelDiagram from '@/components/model/petrinet/tera-model-diagram.vue';
 import TeraModelEquation from '@/components/model/petrinet/tera-model-equation.vue';
@@ -41,7 +40,6 @@ import type { MMT } from '@/model-representation/mira/mira-common';
 const props = defineProps<{
 	model: Model;
 	mmtData: MMT;
-	featureConfig?: FeatureConfig;
 	isGeneratingCard?: boolean;
 }>();
 
diff --git a/packages/client/hmi-client/src/components/model/tera-model.vue b/packages/client/hmi-client/src/components/model/tera-model.vue
index 1d9d2493b7..c51ef67289 100644
--- a/packages/client/hmi-client/src/components/model/tera-model.vue
+++ b/packages/client/hmi-client/src/components/model/tera-model.vue
@@ -1,12 +1,10 @@
 <template>
 	<tera-asset
 		v-bind="$attrs"
-		:feature-config="featureConfig"
 		:id="assetId"
 		:is-loading="isModelLoading"
 		:is-naming-asset="isNaming"
 		:name="temporaryModel?.header.name"
-		@close-preview="emit('close-preview')"
 		:show-table-of-contents="!isWorkflow"
 	>
 		<template #name-input>
@@ -29,7 +27,7 @@
 				/>
 			</div>
 		</template>
-		<template #edit-buttons v-if="!featureConfig.isPreview">
+		<template #edit-buttons>
 			<Button icon="pi pi-ellipsis-v" text rounded @click="toggleOptionsMenu" />
 			<ContextMenu ref="optionsMenu" :model="optionsMenuItems" popup :pt="optionsMenuPt" />
 			<aside class="btn-group">
@@ -48,17 +46,12 @@
 			</aside>
 		</template>
 		<section v-if="temporaryModel && mmtData">
-			<tera-model-description
-				:feature-config="featureConfig"
-				:model="temporaryModel"
-				:mmt-data="mmtData"
-				@update-model="updateTemporaryModel"
-			/>
+			<tera-model-description :model="temporaryModel" :mmt-data="mmtData" @update-model="updateTemporaryModel" />
 			<tera-petrinet-parts
 				:model="temporaryModel"
 				:mmt="mmtData.mmt"
 				:mmt-params="mmtData.template_params"
-				:feature-config="featureConfig"
+				:feature-config="{ isPreview: false }"
 				@update-state="(e: any) => onUpdateModelPart('state', e)"
 				@update-parameter="(e: any) => onUpdateModelPart('parameter', e)"
 				@update-observable="(e: any) => onUpdateModelPart('observable', e)"
@@ -81,7 +74,7 @@
 </template>
 
 <script setup lang="ts">
-import { computed, PropType, ref, watch, onMounted } from 'vue';
+import { computed, ref, watch, onMounted } from 'vue';
 import { cloneDeep, isEmpty, isEqual } from 'lodash';
 import Button from 'primevue/button';
 import ContextMenu from 'primevue/contextmenu';
@@ -92,7 +85,6 @@ import TeraModelDescription from '@/components/model/petrinet/tera-model-descrip
 import TeraPetrinetParts from '@/components/model/petrinet/tera-petrinet-parts.vue';
 import TeraSaveAssetModal from '@/components/project/tera-save-asset-modal.vue';
 import { getModel, updateModel, getMMT } from '@/services/model';
-import type { FeatureConfig } from '@/types/common';
 import { AssetType, type Model } from '@/types/Types';
 import { useProjects } from '@/composables/project';
 import { logger } from '@/utils/logger';
@@ -110,10 +102,6 @@ const props = defineProps({
 		type: String,
 		default: ''
 	},
-	featureConfig: {
-		type: Object as PropType<FeatureConfig>,
-		default: { isPreview: false } as FeatureConfig
-	},
 	isWorkflow: {
 		type: Boolean,
 		default: false
@@ -124,7 +112,7 @@ const props = defineProps({
 	}
 });
 
-const emit = defineEmits(['close-preview', 'on-save']);
+const emit = defineEmits(['on-save']);
 
 const model = ref<Model | null>(null);
 const temporaryModel = ref<Model | null>(null);
@@ -188,7 +176,6 @@ const optionsMenuItems = ref<any[]>([
 				a.click();
 				a.remove();
 			}
-			emit('close-preview');
 		}
 	}
 ]);
diff --git a/packages/client/hmi-client/src/components/workflow/ops/dataset-transformer/tera-dataset-transformer-node.vue b/packages/client/hmi-client/src/components/workflow/ops/dataset-transformer/tera-dataset-transformer-node.vue
index 109e9a9c77..5a2beafa2e 100644
--- a/packages/client/hmi-client/src/components/workflow/ops/dataset-transformer/tera-dataset-transformer-node.vue
+++ b/packages/client/hmi-client/src/components/workflow/ops/dataset-transformer/tera-dataset-transformer-node.vue
@@ -8,7 +8,6 @@
 				v-for="m in node.state.selectedOutputs?.[0]?.messages ?? []"
 				:key="m.header.msg_id"
 				:jupyter-message="m"
-				:feature-config="{ isPreview: true }"
 			/>
 			<Button label="Edit" @click="emit('open-drilldown')" severity="secondary" outlined />
 		</template>