Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: I stratified an already stratified model. The normalized equations do not seem right. #6418

Open
pascaleproulx opened this issue Feb 5, 2025 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@pascaleproulx
Copy link
Contributor

pascaleproulx commented Feb 5, 2025

Describe the bug
I stratified an already stratified model. The normalized equations do not seem right.
S_00to04 was stratified by 3 groups (a, b, c). I created S_00to04_a, S_00to04_b, S_00to04_c. See equations that were used in the normalized option. I was expecting something like S_00to04_a / (S_00to04_a + S_00to04_b + S_00to04_c).

https://app.staging.terarium.ai/projects/1c6e1c59-f162-413a-b0c5-24d70f7b9e32/workflow/47541466-2c71-432f-8d71-7ed6cc7acf0e?operator=166d7321-b638-45e1-bbb3-235e69d1c86f

Screenshots

Image

@pascaleproulx pascaleproulx added the bug Something isn't working label Feb 5, 2025
@jryu01
Copy link
Contributor

jryu01 commented Feb 7, 2025

I think there’s some ambiguity in how the variables are grouped and how the normalization equations should be derived.

For example, when you have just these variables:
• S_00to04_a
• S_00to04_b
• S_00to04_c

It’s unclear whether:
1. They represent a single variable (S_00to04) stratified into three groups (a, b, c).
2. They are three separate variables (S_a, S_b, S_c) with a single group (00to04).

Current implementation does 1

When we look at how the model is stratified in this example (https://app.staging.terarium.ai/projects/1c6e1c59-f162-413a-b0c5-24d70f7b9e32/workflow/47541466-2c71-432f-8d71-7ed6cc7acf0e?operator=166d7321-b638-45e1-bbb3-235e69d1c86f), variable S_00to04 is strafitied with groups a, b, c and if so, the derived equation seems correct with current implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants