Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK]: Reorganize confusing API routes #6489

Open
mwdchang opened this issue Feb 7, 2025 · 0 comments
Open

[TASK]: Reorganize confusing API routes #6489

mwdchang opened this issue Feb 7, 2025 · 0 comments
Labels
task Development task

Comments

@mwdchang
Copy link
Member

mwdchang commented Feb 7, 2025

Some of our API route names are confusing and appear to clash with each other in terms of their functionality. We should take a resource-centric approach for REST APIs, see for example in https://restfulapi.net/resource-naming/

Rename/move

  • GET /models/from-model-configuration/:model-config-id => GET /model-configurations/:id/original-model
  • GET /model-configurations/as-configured-model/:config-id => GET /model-configurations/:id/model
  • PUT /model-configurations/as-configured-model => Remove, doesn't seem to be in use
  • POST /workflows/:id/node/:nodeId/selected-output/:outputId => POST /workflows/:id/node/:nodeId/output/:outputId
@mwdchang mwdchang added the task Development task label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Development task
Projects
None yet
Development

No branches or pull requests

1 participant