From 465f1913c54603d0000002f6b2d30f3bcf8ba2e6 Mon Sep 17 00:00:00 2001 From: Shawn Yama Date: Thu, 1 Aug 2024 15:20:04 -0400 Subject: [PATCH 1/2] rm old props --- packages/client/hmi-client/DEVELOPMENT.md | 4 +--- .../client/hmi-client/src/components/asset/tera-asset.vue | 2 +- .../client/hmi-client/src/components/dataset/tera-dataset.vue | 4 ---- .../workflow/ops/model-comparison/tera-model-comparison.vue | 2 ++ .../src/page/data-explorer/components/tera-asset-card.vue | 2 ++ .../src/page/data-explorer/components/tera-preview-panel.vue | 2 -- 6 files changed, 6 insertions(+), 10 deletions(-) diff --git a/packages/client/hmi-client/DEVELOPMENT.md b/packages/client/hmi-client/DEVELOPMENT.md index 3e20c15dbc..259cbf7a86 100644 --- a/packages/client/hmi-client/DEVELOPMENT.md +++ b/packages/client/hmi-client/DEVELOPMENT.md @@ -81,9 +81,7 @@ Basic rules to write organised code. ```html ``` diff --git a/packages/client/hmi-client/src/components/asset/tera-asset.vue b/packages/client/hmi-client/src/components/asset/tera-asset.vue index 4d0d661039..9ee6bf1535 100644 --- a/packages/client/hmi-client/src/components/asset/tera-asset.vue +++ b/packages/client/hmi-client/src/components/asset/tera-asset.vue @@ -308,7 +308,7 @@ header.with-tabs { display: flex; flex-direction: row; align-items: center; - gap: var(--gap); + gap: var(--gap-2); } .close { diff --git a/packages/client/hmi-client/src/components/dataset/tera-dataset.vue b/packages/client/hmi-client/src/components/dataset/tera-dataset.vue index 0ed2e96497..13b7025519 100644 --- a/packages/client/hmi-client/src/components/dataset/tera-dataset.vue +++ b/packages/client/hmi-client/src/components/dataset/tera-dataset.vue @@ -87,10 +87,6 @@ const props = defineProps({ type: Object as PropType, default: { isPreview: false } as FeatureConfig }, - highlight: { - type: String, - default: null - }, source: { type: String as PropType, default: DatasetSource.TERARIUM diff --git a/packages/client/hmi-client/src/components/workflow/ops/model-comparison/tera-model-comparison.vue b/packages/client/hmi-client/src/components/workflow/ops/model-comparison/tera-model-comparison.vue index e6f8dda506..05abda1ca6 100644 --- a/packages/client/hmi-client/src/components/workflow/ops/model-comparison/tera-model-comparison.vue +++ b/packages/client/hmi-client/src/components/workflow/ops/model-comparison/tera-model-comparison.vue @@ -323,6 +323,8 @@ onMounted(async () => { modelCardsToCompare.value = modelsToCompare.value.map(({ metadata }) => metadata?.gollmCard); fields.value = [...new Set(modelCardsToCompare.value.flatMap((card) => (card ? Object.keys(card) : [])))]; + console.log(modelsToCompare.value); + buildJupyterContext(); processCompareModels(modelIds, props.node.workflowId, props.node.id); }); diff --git a/packages/client/hmi-client/src/page/data-explorer/components/tera-asset-card.vue b/packages/client/hmi-client/src/page/data-explorer/components/tera-asset-card.vue index c16c9b7c44..4a166696dc 100644 --- a/packages/client/hmi-client/src/page/data-explorer/components/tera-asset-card.vue +++ b/packages/client/hmi-client/src/page/data-explorer/components/tera-asset-card.vue @@ -40,6 +40,8 @@
+ + diff --git a/packages/client/hmi-client/src/page/data-explorer/components/tera-preview-panel.vue b/packages/client/hmi-client/src/page/data-explorer/components/tera-preview-panel.vue index d44db4402c..ed3d9c9642 100644 --- a/packages/client/hmi-client/src/page/data-explorer/components/tera-preview-panel.vue +++ b/packages/client/hmi-client/src/page/data-explorer/components/tera-preview-panel.vue @@ -12,7 +12,6 @@ From 7aeaa72ed4bdf01d1b011c25c5254b120598f496 Mon Sep 17 00:00:00 2001 From: Shawn Yama Date: Thu, 1 Aug 2024 15:36:35 -0400 Subject: [PATCH 2/2] rm log --- .../workflow/ops/model-comparison/tera-model-comparison.vue | 2 -- 1 file changed, 2 deletions(-) diff --git a/packages/client/hmi-client/src/components/workflow/ops/model-comparison/tera-model-comparison.vue b/packages/client/hmi-client/src/components/workflow/ops/model-comparison/tera-model-comparison.vue index 05abda1ca6..e6f8dda506 100644 --- a/packages/client/hmi-client/src/components/workflow/ops/model-comparison/tera-model-comparison.vue +++ b/packages/client/hmi-client/src/components/workflow/ops/model-comparison/tera-model-comparison.vue @@ -323,8 +323,6 @@ onMounted(async () => { modelCardsToCompare.value = modelsToCompare.value.map(({ metadata }) => metadata?.gollmCard); fields.value = [...new Set(modelCardsToCompare.value.flatMap((card) => (card ? Object.keys(card) : [])))]; - console.log(modelsToCompare.value); - buildJupyterContext(); processCompareModels(modelIds, props.node.workflowId, props.node.id); });