From 7456e7a452327cc724ae5c123b964d73cfeb18bd Mon Sep 17 00:00:00 2001
From: Cole Blanchard <cblanchard@Cole-Blanchards-MacBook-Pro.local>
Date: Wed, 4 Sep 2024 13:59:12 -0400
Subject: [PATCH 1/3] model config state not stored on outputs

---
 .../tera-model-config-drilldown.vue           | 27 +++++++++++--------
 .../model-config/tera-model-config-node.vue   |  4 +--
 2 files changed, 18 insertions(+), 13 deletions(-)

diff --git a/packages/client/hmi-client/src/components/workflow/ops/model-config/tera-model-config-drilldown.vue b/packages/client/hmi-client/src/components/workflow/ops/model-config/tera-model-config-drilldown.vue
index 834b2a16c7..8b2fc960bf 100644
--- a/packages/client/hmi-client/src/components/workflow/ops/model-config/tera-model-config-drilldown.vue
+++ b/packages/client/hmi-client/src/components/workflow/ops/model-config/tera-model-config-drilldown.vue
@@ -188,8 +188,8 @@
 
 <script setup lang="ts">
 import '@/ace-config';
-import { computed, onUnmounted, ref, watch, nextTick, ComponentPublicInstance } from 'vue';
-import { cloneDeep, isEmpty, orderBy, debounce } from 'lodash';
+import { computed, onUnmounted, ref, watch, nextTick, ComponentPublicInstance, onMounted } from 'vue';
+import { cloneDeep, isEmpty, orderBy, debounce, omit } from 'lodash';
 import Accordion from 'primevue/accordion';
 import AccordionTab from 'primevue/accordiontab';
 import Button from 'primevue/button';
@@ -513,7 +513,7 @@ const createConfiguration = async () => {
 		label: data.name,
 		value: data.id,
 		isSelected: false,
-		state
+		state: omit(state, ['transientModelConfig'])
 	});
 };
 
@@ -526,7 +526,7 @@ const onSaveAsModelConfiguration = (data: ModelConfiguration) => {
 		label: data.name,
 		value: data.id,
 		isSelected: false,
-		state
+		state: omit(state, ['transientModelConfig'])
 	});
 	showSaveModal.value = false;
 };
@@ -551,7 +551,7 @@ const fetchConfigurations = async (modelId: string) => {
 };
 
 // Fill the form with the config data
-const initialize = async () => {
+const initialize = async (overwriteState: boolean = false) => {
 	const state = props.node.state;
 	const modelId = props.node.inputs[0].value?.[0];
 	if (!modelId) return;
@@ -569,9 +569,7 @@ const initialize = async () => {
 		applyConfigValues(suggestedConfigurationContext.value.tableData[0]);
 	} else {
 		originalConfig.value = await getModelConfigurationById(selectedConfigId.value);
-
-		// FIXME: Bug sept-03, state.transientModelConfig may not be saved properly before this date
-		if (state.transientModelConfig.id !== originalConfig.value.id) {
+		if (!overwriteState) {
 			knobs.value.transientModelConfig = cloneDeep(originalConfig.value);
 		} else {
 			knobs.value.transientModelConfig = cloneDeep(state.transientModelConfig);
@@ -637,7 +635,7 @@ const applyConfigValues = (config: ModelConfiguration) => {
 			label: config.name,
 			value: config.id,
 			isSelected: false,
-			state
+			state: omit(state, ['transientModelConfig'])
 		});
 	}
 	logger.success(`Configuration applied ${config.name}`);
@@ -697,6 +695,14 @@ watch(
 	{ deep: true }
 );
 
+onMounted(() => {
+	// setting as true will overwrite the model config with the current state value
+	if (props.node.active) {
+		selectedOutputId.value = props.node.active;
+		initialize(true);
+	}
+});
+
 watch(
 	() => props.node.active,
 	() => {
@@ -704,8 +710,7 @@ watch(
 			selectedOutputId.value = props.node.active;
 			initialize();
 		}
-	},
-	{ immediate: true }
+	}
 );
 
 onUnmounted(() => {
diff --git a/packages/client/hmi-client/src/components/workflow/ops/model-config/tera-model-config-node.vue b/packages/client/hmi-client/src/components/workflow/ops/model-config/tera-model-config-node.vue
index f3894f2101..5c870e0690 100644
--- a/packages/client/hmi-client/src/components/workflow/ops/model-config/tera-model-config-node.vue
+++ b/packages/client/hmi-client/src/components/workflow/ops/model-config/tera-model-config-node.vue
@@ -13,7 +13,7 @@
 </template>
 
 <script setup lang="ts">
-import { cloneDeep } from 'lodash';
+import { cloneDeep, omit } from 'lodash';
 import { computed, watch, ref } from 'vue';
 import { WorkflowNode, WorkflowPortStatus } from '@/types/workflow';
 import Button from 'primevue/button';
@@ -82,7 +82,7 @@ watch(
 					label: config.name,
 					value: config.id,
 					isSelected: false,
-					state
+					state: omit(state, ['transientModelConfig'])
 				});
 			}
 		} else {

From 88bee648f48c49579bb92885bcba196c17eba89b Mon Sep 17 00:00:00 2001
From: Cole Blanchard <cblanchard@Cole-Blanchards-MacBook-Pro.local>
Date: Wed, 4 Sep 2024 15:14:51 -0400
Subject: [PATCH 2/3] rm assignments

---
 .../ops/model-config/tera-model-config-drilldown.vue         | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/packages/client/hmi-client/src/components/workflow/ops/model-config/tera-model-config-drilldown.vue b/packages/client/hmi-client/src/components/workflow/ops/model-config/tera-model-config-drilldown.vue
index c424827489..12a55869d9 100644
--- a/packages/client/hmi-client/src/components/workflow/ops/model-config/tera-model-config-drilldown.vue
+++ b/packages/client/hmi-client/src/components/workflow/ops/model-config/tera-model-config-drilldown.vue
@@ -527,7 +527,6 @@ const createConfiguration = async () => {
 	}
 
 	const state = cloneDeep(props.node.state);
-	state.transientModelConfig = data;
 	useToastService().success('', 'Created model configuration');
 	emit('append-output', {
 		type: ModelConfigOperation.outputs[0].type,
@@ -541,7 +540,6 @@ const createConfiguration = async () => {
 const onSaveAsModelConfiguration = (data: ModelConfiguration) => {
 	useToastService().success('', 'Created model configuration');
 	const state = cloneDeep(props.node.state);
-	state.transientModelConfig = data;
 	emit('append-output', {
 		type: ModelConfigOperation.outputs[0].type,
 		label: data.name,
@@ -648,9 +646,6 @@ const applyConfigValues = (config: ModelConfiguration) => {
 	// If the output does not already exist
 	else {
 		const state = cloneDeep(props.node.state);
-		state.transientModelConfig = config;
-
-		// Append this config to the output.
 		emit('append-output', {
 			type: ModelConfigOperation.outputs[0].type,
 			label: config.name,

From 5796d83c10ce5586ff4b9d4fb56c02dd38773c14 Mon Sep 17 00:00:00 2001
From: Cole Blanchard <cblanchard@Cole-Blanchards-MacBook-Pro.local>
Date: Wed, 4 Sep 2024 15:27:01 -0400
Subject: [PATCH 3/3] var name

---
 .../workflow/ops/model-config/tera-model-config-drilldown.vue | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/packages/client/hmi-client/src/components/workflow/ops/model-config/tera-model-config-drilldown.vue b/packages/client/hmi-client/src/components/workflow/ops/model-config/tera-model-config-drilldown.vue
index 12a55869d9..ab3b6f6ef7 100644
--- a/packages/client/hmi-client/src/components/workflow/ops/model-config/tera-model-config-drilldown.vue
+++ b/packages/client/hmi-client/src/components/workflow/ops/model-config/tera-model-config-drilldown.vue
@@ -570,7 +570,7 @@ const fetchConfigurations = async (modelId: string) => {
 };
 
 // Fill the form with the config data
-const initialize = async (overwriteState: boolean = false) => {
+const initialize = async (overwriteWithState: boolean = false) => {
 	const state = props.node.state;
 	const modelId = props.node.inputs[0].value?.[0];
 	if (!modelId) return;
@@ -588,7 +588,7 @@ const initialize = async (overwriteState: boolean = false) => {
 		applyConfigValues(suggestedConfigurationContext.value.tableData[0]);
 	} else {
 		originalConfig.value = await getModelConfigurationById(selectedConfigId.value);
-		if (!overwriteState) {
+		if (!overwriteWithState) {
 			knobs.value.transientModelConfig = cloneDeep(originalConfig.value);
 		} else {
 			knobs.value.transientModelConfig = cloneDeep(state.transientModelConfig);