From cadd3b56f89b9448abe066f454f0a317f01b7cf5 Mon Sep 17 00:00:00 2001
From: Jamie Waese <120480244+jamiewaese-uncharted@users.noreply.github.com>
Date: Thu, 5 Sep 2024 14:25:09 -0400
Subject: [PATCH 1/2] misc beautification of the Dataset resource

---
 .../src/components/asset/tera-asset.vue           |  2 +-
 .../components/dataset/tera-dataset-datatable.vue |  4 ++--
 .../dataset/tera-dataset-overview-table.vue       |  1 +
 .../src/components/dataset/tera-dataset.vue       | 15 ++++++++++++---
 .../components/widgets/tera-asset-enrichment.vue  |  5 +++--
 5 files changed, 19 insertions(+), 8 deletions(-)

diff --git a/packages/client/hmi-client/src/components/asset/tera-asset.vue b/packages/client/hmi-client/src/components/asset/tera-asset.vue
index 5589d44ed2..5c46e577f8 100644
--- a/packages/client/hmi-client/src/components/asset/tera-asset.vue
+++ b/packages/client/hmi-client/src/components/asset/tera-asset.vue
@@ -275,7 +275,7 @@ header {
 	background-color: var(--surface-0);
 	backdrop-filter: blur(6px);
 	overflow: hidden;
-	z-index: 1;
+	z-index: 3;
 	box-shadow: 0 0 0 0 rgba(0, 0, 0, 0);
 	transition: box-shadow 0.3s;
 }
diff --git a/packages/client/hmi-client/src/components/dataset/tera-dataset-datatable.vue b/packages/client/hmi-client/src/components/dataset/tera-dataset-datatable.vue
index 92a6220635..5ef60e65bf 100644
--- a/packages/client/hmi-client/src/components/dataset/tera-dataset-datatable.vue
+++ b/packages/client/hmi-client/src/components/dataset/tera-dataset-datatable.vue
@@ -3,7 +3,7 @@
 		<!-- Toggle histograms & column summary charts -->
 		<div class="datatable-toolbar">
 			<span class="datatable-toolbar-item">
-				{{ rawContent.headers.length || 'No' }} columns | {{ rawContent.csv.length || 'No' }} rows
+				{{ rawContent.headers.length || 'No' }} columns | {{ rawContent.csv.length - 1 || 'No' }} rows
 			</span>
 			<span class="datatable-toolbar-item" style="margin-left: auto">
 				Show column summaries<InputSwitch v-model="showSummaries" />
@@ -238,7 +238,7 @@ watch(
 	display: flex;
 	flex-direction: row;
 	gap: var(--gap);
-	padding-bottom: var(--gap);
+	padding-bottom: var(--gap-2);
 }
 .datatable-toolbar-item {
 	display: flex;
diff --git a/packages/client/hmi-client/src/components/dataset/tera-dataset-overview-table.vue b/packages/client/hmi-client/src/components/dataset/tera-dataset-overview-table.vue
index fdf321e911..f42197920e 100644
--- a/packages/client/hmi-client/src/components/dataset/tera-dataset-overview-table.vue
+++ b/packages/client/hmi-client/src/components/dataset/tera-dataset-overview-table.vue
@@ -122,6 +122,7 @@ watch(
 
 .p-datatable:deep(.p-datatable-thead > tr > th) {
 	background-color: var(--surface-50);
+	padding-left: var(--gap);
 }
 
 .concept,
diff --git a/packages/client/hmi-client/src/components/dataset/tera-dataset.vue b/packages/client/hmi-client/src/components/dataset/tera-dataset.vue
index 296b5cb833..b2f1996744 100644
--- a/packages/client/hmi-client/src/components/dataset/tera-dataset.vue
+++ b/packages/client/hmi-client/src/components/dataset/tera-dataset.vue
@@ -39,13 +39,13 @@
 			</div>
 		</template>
 		<section>
-			<div class="m-3">
+			<div class="pl-4 ml-3 pt-1 pb-3">
 				<p>
-					<span class="font-bold inline-block w-10rem">Dataset Id</span>
+					<span class="font-semibold inline-block w-10rem">Dataset ID</span>
 					<code class="inline">{{ datasetInfo.id }}</code>
 				</p>
 				<p>
-					<span class="font-bold inline-block w-10rem">Dataset Filenames</span>
+					<span class="font-semibold inline-block w-10rem">Dataset filenames</span>
 					{{ datasetInfo.fileNames }}
 				</p>
 			</div>
@@ -69,6 +69,7 @@
 						v-if="dataset"
 						:dataset="dataset"
 						@update-dataset="(dataset: Dataset) => updateAndFetchDataset(dataset)"
+						class="column-information-table"
 					/>
 				</AccordionTab>
 				<template v-else-if="dataset?.metadata">
@@ -368,6 +369,9 @@ watch(
 </script>
 
 <style scoped>
+.column-information-table {
+	border: 1px solid var(--surface-border-light);
+}
 .btn-group {
 	display: flex;
 	align-items: center;
@@ -396,4 +400,9 @@ watch(
 .col {
 	flex: 1;
 }
+
+/* Add gaps beneath open accordions */
+:deep(.p-accordion-content) {
+	padding-bottom: var(--gap-6) !important;
+}
 </style>
diff --git a/packages/client/hmi-client/src/components/widgets/tera-asset-enrichment.vue b/packages/client/hmi-client/src/components/widgets/tera-asset-enrichment.vue
index 85cc8f344e..bf80b81f2e 100644
--- a/packages/client/hmi-client/src/components/widgets/tera-asset-enrichment.vue
+++ b/packages/client/hmi-client/src/components/widgets/tera-asset-enrichment.vue
@@ -1,6 +1,7 @@
 <template>
 	<Button
 		label="Enrich metadata with AI assistant"
+		icon="pi pi-sparkles"
 		:loading="isLoading"
 		severity="secondary"
 		outlined
@@ -15,7 +16,7 @@
 			without additional context.
 		</p>
 		<ul>
-			<li v-for="document in documents" :key="document.id">
+			<li v-for="document in documents" :key="document.id" :class="document.id ? '' : 'mb-3'">
 				<RadioButton inputId="document.id" name="document.id" v-model="selectedResourceId" :value="document.id" />
 				<label :for="document.id">{{ document.name }}</label>
 			</li>
@@ -30,7 +31,7 @@
 				<Checkbox v-model="overwriteContent" inputId="overwriteContent" binary />
 				<div class="ml-3">
 					<label for="overwriteContent">Overwrite existing content</label>
-					<p class="text-subdued">If unselected, new content will be appeded</p>
+					<p class="text-subdued">If unselected, new content will be appended</p>
 				</div>
 			</div>
 		</template>

From a349224ca1d07cd6b7e425360a9058b1a48e0259 Mon Sep 17 00:00:00 2001
From: Jamie Waese <120480244+jamiewaese-uncharted@users.noreply.github.com>
Date: Thu, 5 Sep 2024 15:20:16 -0400
Subject: [PATCH 2/2] adjuste nav min-width to prevent wiggle when you scroll

---
 packages/client/hmi-client/src/components/asset/tera-asset.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/client/hmi-client/src/components/asset/tera-asset.vue b/packages/client/hmi-client/src/components/asset/tera-asset.vue
index 5c46e577f8..8f80433b0a 100644
--- a/packages/client/hmi-client/src/components/asset/tera-asset.vue
+++ b/packages/client/hmi-client/src/components/asset/tera-asset.vue
@@ -263,7 +263,7 @@ nav {
 }
 
 .nav-item {
-	min-width: 9rem;
+	min-width: 9.5rem;
 }
 header {
 	display: flex;