Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getTimeRatio in PlaybackWarpProcessor should be double, not bool #81

Closed
auryd opened this issue Apr 3, 2022 · 3 comments
Closed

getTimeRatio in PlaybackWarpProcessor should be double, not bool #81

auryd opened this issue Apr 3, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@auryd
Copy link
Contributor

auryd commented Apr 3, 2022

(Also, PlaybackWarpProcessor seems to always go into an infinite loop on render. I haven't been able to figure out why yet, so I hadn't filed an issue on that yet in case I'm just doing something wrong and it's expected behavior under some conditions?

For example, I can load an audio file into a PlaybackProcessor, and it works fine. But if I change the PlaybackProcessor to a PlaybackWarpProcessor, it infinite loops when I call engine.render.)

@DBraun
Copy link
Owner

DBraun commented Apr 4, 2022

Thanks. You're right about both. getTimeRatio will definitely get fixed in the next update, and I'm looking at playback warp processor again. There appears to be an issue when there isn't a warp file.

@DBraun DBraun self-assigned this Apr 4, 2022
@DBraun DBraun added the bug Something isn't working label Apr 4, 2022
@DBraun
Copy link
Owner

DBraun commented Apr 5, 2022

Can you install the latest and take a look at

def test_playbackwarp_processor3():
for reference

@DBraun
Copy link
Owner

DBraun commented Apr 18, 2022

Closing. Please comment if there's still an issue.

@DBraun DBraun closed this as completed Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants