Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure source is checked out for Sonar scan to work #2014

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Ensure source is checked out for Sonar scan to work #2014

merged 1 commit into from
Dec 3, 2024

Conversation

DrizzlyOwl
Copy link
Collaborator

  • without the source, the sonar-project.properties file is missing which prevents Sonarcloud from understanding how we want it to scan the project

@DrizzlyOwl
Ensure source is checked out for Sonar scan to work
e51126e 
* without the source, the sonar-project.properties file is missing which prevents Sonarcloud from understanding how we want it to scan the project
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

edavey
edavey approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@edavey edavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. How was the CI action working before?

@DrizzlyOwl
Copy link
Collaborator Author

Thanks for fixing this. How was the CI action working before?

The checkout line was inadvertently removed by me

@DrizzlyOwl DrizzlyOwl merged commit 2c02a9a into main Dec 3, 2024
10 checks passed
@DrizzlyOwl DrizzlyOwl deleted the hotfix/sonar branch December 3, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edavey edavey edavey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrizzlyOwl @edavey