20210323180540_change_item_id_type_to_uuid.rb changes column type and throws any data away

[blackrat]

This is a migration that converts the papertrail item_id from bigint to uuid by dropping the column and recreating it with random data. This will break the referential integrity of the papertrail items, rendering them useless up to the point of the migration.

The original foreign key data was lost by this migration. In addition, you can't roll back, since that will fail.

[timabell]

This was the patch 63e38d6#diff-9c91cc95430a94f2177c34b7538ef8227fb779c91c7a8647082e1338d64003e1R5

early-careers-framework/db/migrate/20210323180540_change_item_id_type_to_uuid.rb

Lines 5 to 7 in 63e38d6

	remove_column :versions, :item_id, :bigint
	remove_index :versions, column: %i[item_type item_id], if_exists: true
	add_column :versions, :item_id, :uuid, default: "gen_random_uuid()", null: false

[ethanmills]

The original foreign key data was lost by this migration

There wasn't any original foreign key data to lose. Firstly, this was before we deployed to production. Secondly, since UUIDs were being cast to ints, we only had the characters of the ID before the first letter.

Is there a change you'd like here, or can we close this?

[blackrat]

Close it.