Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview HTB template #58

Merged
merged 3 commits into from
Jun 28, 2021
Merged

Preview HTB template #58

merged 3 commits into from
Jun 28, 2021

Conversation

madeviv
Copy link
Contributor

@madeviv madeviv commented Jun 28, 2021 •
edited
Loading

  • Preview summary card for rationale
  • Preview summary card for risks and issues
  • Preview summary card for school performance ofsted
  • Preview summary card for school budget info
  • Move school and trust info summary rows to reusable view component
  • Query string redirect logic to get back to preview page
  • Update back link tag helper
  • Per request caching for establishment
  • Remove -empty postfix for summary row Id to make integration testing easier

@madeviv madeviv requested a review from rf-mt June 28, 2021 11:12
rf-mt
rf-mt approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@rf-mt rf-mt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It won't let me leave a comment on this but can line 6 of ConfirmSchoolAndTrustInformation.cshtml be removed now?

@madeviv madeviv merged commit c1c5e72 into master Jun 28, 2021
@madeviv madeviv deleted the feat/preview-htb-template branch June 28, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rf-mt rf-mt rf-mt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madeviv @rf-mt