Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DHLabs/keep update #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

DHLabs/keep update #16

wants to merge 2 commits into from

Conversation

jianlins
Copy link

Test

@wesvetter
Copy link
Member

Thanks for the pull-request, we could definitely use some help with documentation. We try not to include any binary files in the repo though, plain-text documentation is easier to track in Git. Github automatically renders README documents in any folder, so README.md documents in the appropriate folder are the preferred form of documentation (e.g. the style guides in frontend/coffeescript or frontend/sass.

Some of this is already covered in the READMEs or specific to other tools (like database browsers), but if you want to add some stuff to the existing docs, update this PR and I'll take a look at. keepbackend/README.txt needs to be converted to a Markdown document, if you want to that tackle that we'd certainly appreciate it.

In the "modification of code" section you mention a possible bug. Can you file this as a separate issue and I'll take a look at it next week?

There also seems to be a commit related to the twofactor submodule. Was that added by accident?

@jianlins
Copy link
Author

Hi, Wes,

Thank you for reply. I have to apologize, I'm new to GitHub and not sure
how pulling works. I often only use the git through ide or command. Can you
directly tell you what need to do?

Thank you!

Jianlin

---send from my phone
On Apr 18, 2015 12:30 AM, "Wes Vetter" notifications@github.com wrote:

Thanks for the pull-request, we could definitely use some help with
documentation. We try not to include any binary files in the repo though,
plain-text documentation is easier to track in Git. Github automatically
renders README documents in any folder, so README.md documents in the
appropriate folder are the preferred form of documentation (e.g. the style
guides in frontend/coffeescript or frontend/sass.

Some of this is already covered in the READMEs or specific to other tools
(like database browsers), but if you want to add some stuff to the existing
docs, update this PR and I'll take a look at. keepbackend/README.txt
needs to be converted to a Markdown document, if you want to that tackle
that we'd certainly appreciate it.

In the "modification of code" section you mention a possible bug. Can you
file this as a separate issue and I'll take a look at it next week?

There also seems to be a commit related to the twofactor submodule. Was
that added by accident?


Reply to this email directly or view it on GitHub
#16 (comment).

@wesvetter
Copy link
Member

Easiest thing is probably just to create a new branch, make the relevant changes to the READMEs on that branch, and then make a new pull request for that branch.

@jianlins
Copy link
Author

Ok. Thanks.

Jianlin

---send from my phone
On Apr 18, 2015 10:44 PM, "Wes Vetter" notifications@github.com wrote:

Easiest thing is probably just to create a new branch, make the relevant
changes to the READMEs on that branch, and then make a new pull request for
that branch.


Reply to this email directly or view it on GitHub
#16 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants