forked from mattfemia/excuse-me
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathedits.txt
18 lines (15 loc) · 847 Bytes
/
edits.txt
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
- When viewed as a Chrome extension, everything goes out of view. I made the following
CSS edits:
- .container {padding: 200px -> 0px}
- h1 {font-size: 100px -> 70px}
- Chrome extension was throwing an error because we had inline JS on index.html
to handle the category dropdown. Edits to handle that:
- Move all the JS to main.js
- Create id "categorySelector" for button.btn in index.html (the category button)
- Add selector and click eventListener for categorySelector in main.js
- Renamed the dropdown function myFunction -> dropdownToggle in main.js
- Added comments on main.js for clarity of each block
- manifest.json didn't work properly
- Had to change: manifest version, content_scripts url
- Had to add title
- Had to add the 'action' for it to popup when clicked