New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Implement new lyrics API in DownloadServer too #1

Closed

DJDoubleD opened this issue Jul 22, 2024 · 1 comment

Assignees

Labels

Owner

DJDoubleD commented Jul 22, 2024 •

edited

Loading

Implement new lyrics API in java DownloadServer like in UI.
Downloading lyrics now gives JSON exception for tracks that only use new API

Example album: https://www.deezer.com/us/album/589673702

W:2024.07.23 01:21:39 (TrackID: 2811095062, ID: 24): Error downloading lyrics! org.json.JSONException: No value for LYRICS SYNC_JSON

The text was updated successfully, but these errors were encountered:

DJDoubleD self-assigned this

DJDoubleD added the enhancement label

DJDoubleD changed the title ~~[Feature] Implement new lyrics API in DownloadServer to~~ [Feature] Implement new lyrics API in DownloadServer too

Owner Author

DJDoubleD commented Jul 24, 2024

New API with fallback to old method implemented in commit 3a29640.
Also moved fetching lyrics back to the post-processing & only when requested true settings in commit 14a6e94.
Lyrics availability in UI should now match downloaded lyrics.
A warning is printed in error log if lyrics are requested but none were returned/available.

DJDoubleD closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment