-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[question] All checkpoints use the same VecNormalize statistics #278
Comments
Hello, The other thing is that the normalization should converge at some point and therefore using the last stats for evaluating earlier checkpoints should not affect too much the results. |
It makes a lot of sense to me. Thank you for reply. Saving each checkpoint stats may cost space and, in general, is not necessary. Probably, It is reasonable and practical to save the stats of p.s. the code does save checkpoint stat for |
I would welcome a PR that does this ;) |
Hi, I actually implemented one for personal use. Let me clean it and make a PR. |
Hi,
I find parameter
save_freq
andeval_freq
enable us to save checkpoints during training:rl_model_{num_timesteps}_steps.zip
best_model.zip
However, we do not have normalization statistics at the moment we save them. There is only one
vecnormalize.pkl
saved by functionsave_trained_model()
after training where we save checkpoint{env_id}.zip
(refer to this link).When we evaluate one of the checkpoints (rl_model_{num_timesteps}_steps.zip, best_model.zip, {env_id}.zip), we use the same normalization statistics (refer to this link). Does this affect the evaluation? Why do we not save the normalization statistics for every checkpoints?
Thank you!
The text was updated successfully, but these errors were encountered: