Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Is DQN actually Double DQN? #1737

Closed
4 tasks done
oliverc1623 opened this issue Nov 6, 2023 · 2 comments
Closed
4 tasks done

[Question] Is DQN actually Double DQN? #1737

oliverc1623 opened this issue Nov 6, 2023 · 2 comments
Labels
duplicate This issue or pull request already exists question Further information is requested RTFM Answer is the documentation

Comments

@oliverc1623
Copy link

oliverc1623 commented Nov 6, 2023

❓ Question

Hi, first off great work on making Stable-Baselines3 an excellent resource for deep reinforcement learning practitioners.

I noticed that your DQN implementation features a target q network which resembles Google's Deep Mind paper, Deep Reinforcement Learning with Double Q-learning. Meanwhile, Neural Fitted Q Iteration, by Riedmiller, calculates the target using the "current estimate" of the Q function. I am looking for clarification if DQN is truly a Double DQN. I hope to use this information to accurately hopefully implement prioritized experience replay based off of your DQN implementation.

Thanks,
Oliver

Checklist

@oliverc1623 oliverc1623 added the question Further information is requested label Nov 6, 2023
@araffin araffin added duplicate This issue or pull request already exists RTFM Answer is the documentation labels Nov 6, 2023
@araffin
Copy link
Member

araffin commented Nov 6, 2023

Duplicate of #487

It is not, current DQN is the vanilla DQN (cf. doc), but we are working (and welcome help) on #622 (there is a PR for PER).
However, we do provide QR-DQN in SB3 contrib repo.

@oliverc1623
Copy link
Author

Thanks for the clarification, will read up on #487 and the papers more throughly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists question Further information is requested RTFM Answer is the documentation
Projects
None yet
Development

No branches or pull requests

2 participants