Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CSS assets for easier management #1862

Closed
3 of 4 tasks
Bodacious opened this issue Sep 6, 2018 · 3 comments
Closed
3 of 4 tasks

Refactor CSS assets for easier management #1862

Bodacious opened this issue Sep 6, 2018 · 3 comments
Assignees

Comments

@Bodacious
Copy link
Contributor

Bodacious commented Sep 6, 2018

The CSS assets are not organised very neatly. We need to refactor these to make it easier to support custom branding.

  • Move CSS assets back to Rails's asset pipeline
  • Add support for LibC Sass (faster compilation)
  • Refactor CSS file structure for maintainability
  • Normalise CSS variables
@sjDCC
Copy link
Contributor

sjDCC commented Dec 4, 2018

haven't noticed any issues in display with branding so assume this is ok. this is just based on general visual checks as I have done overall UAT. @xsrust @briri Can you advise if there are specific things I should test?

@briri
Copy link
Contributor

briri commented Dec 5, 2018

Anything that includes Javascript (e.g. questions load when you expand a section, table sorting, etc.) and the site's look and feel (CSS).

@sjDCC
Copy link
Contributor

sjDCC commented Dec 7, 2018

All looks good to me. Table sort and search works well and all accordians open. Only issue I spotted is that links open in same window. We used to have it force a new window to be opened. Will raise a ticket for that and close this one out

@sjDCC sjDCC closed this as completed Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants