Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development #3289

Merged
merged 74 commits into from
Feb 3, 2023
Merged

Development #3289

merged 74 commits into from
Feb 3, 2023

Conversation

benjaminfaure
Copy link
Contributor

@benjaminfaure benjaminfaure commented Feb 3, 2023

Bug Fixes

  • Updated sans-serif font used in PDF downloads to Roboto since Google API no longer offers Helvetica
  • Fixed discrepencies with default/max per_page values for API and UI pagination
  • Updated JS that used to call the TinyMCE setMode() function so that it now calls mode.set() because the former is now deprecated.
  • Patched an issue that was causing a template's visibility to change to 'organizationally_visible' when saving on the template details page.
  • Fixed an issue with the Rails 6 keyword arguments change that was causing the paginable_sort_link to fail

Changes

  • Added validation with custom error message in research_output.rb to ensure a user does not enter a very large value as 'Anticipated file size'. #3161
  • Added popover for org profile page and added explanation for public plan
  • Updated the CSV export so that it now includes research outputs
  • Change csv file name for statistics from 'Completed' to 'Created'

Developers

  • Added CHANGELOG.md and Danger Github Action #3257
  • Froze mail gem version #3254
  • Added scss files to EditorConfig
  • Updated Ruby & JS dependencies

benjaminfaure and others added 27 commits January 24, 2023 15:00
Change csv file name for statistics from 'Completed' to 'Created'
add popover for org_profile page and add explanation for public plan
…ganizationally_visible even when the org is a funder
fix to properly use max per page settings
Switched Google font used in PDFs from Helvetica to Roboto
Fix KeywordArgs issue in Paginable concern
added research outputs to the CSV download of the plan
Template visibility changed to organizationally_visible
@github-actions
Copy link

github-actions bot commented Feb 3, 2023

</tr>
1 Error
🚫

Please include a CHANGELOG entry.

You can find it at [CHANGELOG.md](https://github.com/DMPRoadmap/roadmap/blob/main/CHANGELOG.md).
2 Warnings
⚠️ Please add a detailed summary in the description.
⚠️ This PR is too big! Consider breaking it down into smaller PRs.

Generated by 🚫 Danger

@benjaminfaure
Copy link
Contributor Author

Seems like Danger is expecting a CHANGELOG file in main branch. I think it's safe to merge because this PR includes the addition of Danger.

@benjaminfaure benjaminfaure merged commit d95a1a9 into main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants