Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade DNN dependencies #69

Open
valadas opened this issue Dec 8, 2023 · 2 comments
Open

Upgrade DNN dependencies #69

valadas opened this issue Dec 8, 2023 · 2 comments

Comments

@valadas
Copy link
Member

valadas commented Dec 8, 2023

This module currently targets DNN 9.1.1 and some webcontrols in DotNetNuke.UI.WebControls that we only have a DLL for and no source code. Those controls may disappear from DNN in the future without a good ability to announce deprecations about them.

In addition to that, the dashboard view is pretty broken right now and may need a larger effort to bring back to life. See #51

@juvander are you still willing to maintain this module ?

@stetard would you like to tackle some of this ?

I am happy to help anyone who would like to tackle any of this but as I don't use that module, I don't plan on doing all of this myself as I don't have a great test bed or experience with the module.

If anyone intends to help on that, let me know and we can do it together in our co-coding sessions or similar.

@stetard
Copy link
Contributor

stetard commented Dec 8, 2023

@valadas I think I could try to review some parts of this module. I don't use it so much but I already used it and some of my customers use it.
Can you pinpoint precisely the changes you're expecting? Which DNN version should be referenced? Which controls need to be replaced?
Maybe I can try to take a look at the code before the end of year. Then, I will go back to you to share my suggestions if it's ok for you.

@valadas
Copy link
Member Author

valadas commented Dec 8, 2023

Sure, so I'd like for this module to target the oldest DNN version that has no published security bulletins (which means v9.11.0) if you do that nuget package upgrade and try to build, the controls affected will be highlighted red. It is not a ton but they all pretty much relate to Node and NodeList controls.

And then a lot of the recent fixes done on the main module are probably just not implemented in the dashboard one but I ran out of time to confirm it was the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants