Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BulletDskShape doesn't properly work with multi-segment DSKs #3176

Closed
jessemapel opened this issue Mar 26, 2019 · 0 comments · Fixed by #3181
Closed

BulletDskShape doesn't properly work with multi-segment DSKs #3176

jessemapel opened this issue Mar 26, 2019 · 0 comments · Fixed by #3181
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jessemapel
Copy link
Contributor

ISIS version(s) affected: 3.7.0 (pre-release)

Description

The methods in BulletDskShape only access the first segment.

How to reproduce

The unit test it self has issues. For the multi-segment test, it should have 26 vertices and 28 plates.

This is primarily present in BulletDskShape::getNumTriangles, BulletDskShape::getNumVertices, and BulletDskShape::getTriangle

Possible Solution

We need to iterate over all the segments when counting things. We also need to determine how we want BulletDskShape::getTriangle to work. We could implement a linear indexing where the indexing for each segment starts after the end of the previous. Another option would be indexing by both the segment index and the plate index.

@jessemapel jessemapel added this to the 3.7.0 milestone Mar 26, 2019
@jessemapel jessemapel added the bug Something isn't working label Mar 26, 2019
@USGSsakins USGSsakins added the in progress doing the things label Mar 26, 2019
@jessemapel jessemapel removed in progress doing the things labels Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants