-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is the ISIS3 Anaconda tarball so large? #674
Comments
I modified the build.sh script to include the -DCMAKE_BUILD_TYPE=Release flag, but this did not seem to make a difference. |
So I pulled the linux and OSX tar balls from anaconda. The linux one has (decompressed) 900+MB of documentation and ~60MB of binaries. The OSX version has ~90MB of binaries, but 'only' 735MB of docs. So, the problem here is that we are shipping documentation inside of a source code archive. The fix is going to be to get the documentation out of the upload to anaconda and then push the documentation to someplace more sensical. Also, it looks like the largest files are in the Developer and Programmer docs... |
It also looks like we are shipping user documentation in here on the order of 300MB. This is duplicated between tabbed and printer friendly. |
For right now, I will probably remove the docs from the build. We can put the docs on rsync or something if we really want people to be able to download them. |
👍 I also heard back from the anaconda team - they do not offer larger storage hosting options. |
Do docs need to be on system? Maybe offer online docs, a nicely compressed PDF, or an optional download. Personally I never use the local docs with ISIS3, just the online resources. |
Having local documentation is useful to a user when they are not online, and in the past, when the USGS website has had connection problems, having the docs locally was helpful. If the 'online' docs can be hosted on a server with more reliable uptime, then this second concern is mitigated, but you always want to be able to serve the first concern. So I have some opinions (surprise!):
|
@rbeyer I like the idea of having a command to build the app docs in the release. We cannot build the dev docs in the release though. A lot of the documentation is in the cpp files that are not included in the distribution. |
I think that would be fine. I think the 'need' of offline docs is the app-level docs that give more info than what you get from -h. |
I just created an RFC for this so that we can have a clear idea of what is being discussed. We can use this issue to get everyone on the same page and then go ahead and get PR(s) in with the necessary changes. |
For reference, I am removing the docs from the current release because it shaves several hours off of the packaging and build time. This has caused the OSX tarball to go from 200 MB to 12MB. |
No one has provided any more feedback against this, so I'm going to go ahead and close this out ~2 weeks from now on February 28th. |
Are you all talking about the online documentation? I'm trying to understand what the impact might be locally, but I don't understand the problem well enough to ask the right question or make an appropriate comment. I have the ISIS 3 Application Documentation web page opened all of the time as work - is that going to be impacted somehow? |
@lwellerastro The online docs will not be impacted. We previously provided an offline copy of the docs with every ISIS install. Because it takes up about 50 times as much space as the rest of the ISIS install, it's the logical place to reduce the size of our install. |
Thanks @jessemapel ! |
@ALL Still planning to close this tomorrow unless someone thinks we shouldn't. So, far this has de facto been implemented for 3.6.1 and 3.6.2 due to cloud size limitations. |
Is there a fix for those individuals that want an offline version of the docs, or a version hosted elsewhere? For example, during the government shutdown the ISIS documentation website was unavailable. |
You are still able to build the documentation from the repository. After configuring with cmake the |
While not ideal, it is certainly sufficient. Seems good to close. |
Closing this off:
|
The Anaconda ISIS3 tarball is ~500 MB for linux and ~250 MB for mac.
This is far too large. We need to figure out why.
The text was updated successfully, but these errors were encountered: