Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Separate t4c license server and instance #1866

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

zusorio
Copy link
Member

@zusorio zusorio commented Oct 1, 2024

Until now, T4C instances had a field for setting up a license server. This was a problem because
setting up multiple instances meant inputting duplicate license server details. Now, users create a
license server and link it to one or more instances.

Breaking Changes

  • All API routes below /api/v1/settings/modelsources/t4c were modified and split into different routes for license servers and T4C server instances. Make sure to update your scripts accordingly.
  • The existing "TeamForCapella" Grafana dashboard was copied into "TeamForCapella Legacy" dashboard. The old dashboard doesn't provide new data anymore after this release, but can be used to view historical data.

Copy link

github-actions bot commented Oct 1, 2024

A Storybook preview is available for commit 3484369.
➡️ View Storybook
➡️ View Chromatic build

This comment has been minimized.

@zusorio zusorio force-pushed the separate-t4c-license-server branch from 313f4d3 to 3c70b29 Compare October 1, 2024 15:27
Copy link

github-actions bot commented Oct 1, 2024

The generated OpenAPI client is not up to date with the latest changes in the OpenAPI specification.
Please run make openapi locally and commit the changes.

This comment has been minimized.

@zusorio zusorio force-pushed the separate-t4c-license-server branch from 3c70b29 to a0b226f Compare October 2, 2024 14:18
@zusorio zusorio changed the title feat: Separate t4c license server and instance feat!: Separate t4c license server and instance Oct 2, 2024
@zusorio zusorio marked this pull request as ready for review October 2, 2024 14:19
@zusorio zusorio requested a review from MoritzWeber0 as a code owner October 2, 2024 14:19
Copy link

github-actions bot commented Oct 2, 2024

The generated OpenAPI client is not up to date with the latest changes in the OpenAPI specification.
Please run make openapi locally and commit the changes.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 89.82456% with 29 lines in your changes missing coverage. Please review.

Project coverage is 84.60%. Comparing base (352a1cb) to head (1b87f79).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...tings/modelsources/t4c/license_server/interface.py 58.97% 11 Missing and 5 partials ⚠️
...ollab/settings/modelsources/t4c/instance/routes.py 91.11% 2 Missing and 2 partials ⚠️
...b/settings/modelsources/t4c/license_server/crud.py 91.66% 1 Missing and 1 partial ⚠️
...ings/modelsources/t4c/license_server/exceptions.py 87.50% 2 Missing ⚠️
...ngs/modelsources/t4c/license_server/injectables.py 75.00% 1 Missing and 1 partial ⚠️
...ettings/modelsources/t4c/license_server/metrics.py 80.00% 0 Missing and 2 partials ⚠️
...b/settings/modelsources/t4c/instance/exceptions.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1866      +/-   ##
==========================================
+ Coverage   84.45%   84.60%   +0.15%     
==========================================
  Files         197      203       +6     
  Lines        6554     6691     +137     
  Branches      730      742      +12     
==========================================
+ Hits         5535     5661     +126     
- Misses        858      866       +8     
- Partials      161      164       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

@zusorio zusorio force-pushed the separate-t4c-license-server branch from a0b226f to 9a12b6c Compare October 2, 2024 14:25
Copy link

github-actions bot commented Oct 2, 2024

The generated OpenAPI client is not up to date with the latest changes in the OpenAPI specification.
Please run make openapi locally and commit the changes.

This comment has been minimized.

@zusorio zusorio force-pushed the separate-t4c-license-server branch 2 times, most recently from f4c4864 to 7033a8f Compare October 2, 2024 14:41

This comment has been minimized.

@zusorio zusorio force-pushed the separate-t4c-license-server branch from 7033a8f to 0dc77d0 Compare October 2, 2024 14:56

This comment has been minimized.

@DSD-DBS DSD-DBS deleted a comment from github-actions bot Oct 4, 2024
MoritzWeber0 added a commit that referenced this pull request Oct 4, 2024
MoritzWeber0 added a commit that referenced this pull request Oct 4, 2024
@MoritzWeber0 MoritzWeber0 force-pushed the separate-t4c-license-server branch from 7dd9109 to 61cfa05 Compare October 4, 2024 15:27
Copy link

github-actions bot commented Oct 4, 2024

The generated OpenAPI client is not up to date with the latest changes in the OpenAPI specification.
Please run make openapi locally and commit the changes.

This comment has been minimized.

Copy link

github-actions bot commented Oct 4, 2024

The generated OpenAPI client is not up to date with the latest changes in the OpenAPI specification.
Please run make openapi locally and commit the changes.

This comment has been minimized.

MoritzWeber0 added a commit that referenced this pull request Oct 4, 2024
@MoritzWeber0 MoritzWeber0 force-pushed the separate-t4c-license-server branch from 61cfa05 to 9524c73 Compare October 4, 2024 15:43
Copy link

github-actions bot commented Oct 4, 2024

The generated OpenAPI client is not up to date with the latest changes in the OpenAPI specification.
Please run make openapi locally and commit the changes.

This comment has been minimized.

MoritzWeber0 added a commit that referenced this pull request Oct 7, 2024
@MoritzWeber0 MoritzWeber0 force-pushed the separate-t4c-license-server branch from 9524c73 to d0feba1 Compare October 7, 2024 12:26

This comment has been minimized.

MoritzWeber0 added a commit that referenced this pull request Oct 7, 2024
@MoritzWeber0 MoritzWeber0 force-pushed the separate-t4c-license-server branch from d0feba1 to 02517c9 Compare October 7, 2024 15:18

This comment has been minimized.

MoritzWeber0 added a commit that referenced this pull request Oct 7, 2024
@MoritzWeber0 MoritzWeber0 force-pushed the separate-t4c-license-server branch from 02517c9 to e805c31 Compare October 7, 2024 15:29
Until now, T4C instances had a field for setting up a license server. This was a problem because
setting up multiple instances meant inputting duplicate license server details. Now, users create a
license server and link it to one or more instances.

This comment has been minimized.

@MoritzWeber0 MoritzWeber0 force-pushed the separate-t4c-license-server branch from e805c31 to 1b87f79 Compare October 7, 2024 15:32
Copy link

sonarcloud bot commented Oct 7, 2024

Copy link

github-actions bot commented Oct 7, 2024

This report was generated by comparing 3484369 with 352a1cb.
If you would like to check difference, please check here.

change detected

ArtifactName: reg

item count
pass 298
change 12
new 8
delete 0
📝 Report

Differences

Settings Components_Modelsources_T4C_Server Instance_Add Instance_desktop.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_T4C_Server Instance_Add Instance_mobile.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_T4C_Server Instance_Archived Instance_desktop.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_T4C_Server Instance_Archived Instance_mobile.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_T4C_Server Instance_Edit Existing Instance_desktop.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_T4C_Server Instance_Edit Existing Instance_mobile.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_T4C_Server Instance_Existing Instance_desktop.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_T4C_Server Instance_Existing Instance_mobile.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_T4C_Server Overview_Loading_desktop.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_T4C_Server Overview_Loading_mobile.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_T4C_Server Overview_Overview_desktop.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_T4C_Server Overview_Overview_mobile.png

actual Actual
expected Expected
difference Difference

New Items

Settings Components_Modelsources_T4C_License Server_Add License Server_desktop.png

NewItem

Settings Components_Modelsources_T4C_License Server_Add License Server_mobile.png

NewItem

Settings Components_Modelsources_T4C_License Server_Existing License Server_desktop.png

NewItem

Settings Components_Modelsources_T4C_License Server_Existing License Server_mobile.png

NewItem

Settings Components_Modelsources_T4C_License Server_Existing Unreachable License Server_desktop.png

NewItem

Settings Components_Modelsources_T4C_License Server_Existing Unreachable License Server_mobile.png

NewItem

Settings Components_Modelsources_T4C_License Server_Existing Unused License Server_desktop.png

NewItem

Settings Components_Modelsources_T4C_License Server_Existing Unused License Server_mobile.png

NewItem

@MoritzWeber0 MoritzWeber0 merged commit 840d91f into main Oct 7, 2024
32 checks passed
@MoritzWeber0 MoritzWeber0 deleted the separate-t4c-license-server branch October 7, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants