-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Separate t4c license server and instance #1866
Conversation
A Storybook preview is available for commit 3484369. |
This comment has been minimized.
This comment has been minimized.
313f4d3
to
3c70b29
Compare
The generated OpenAPI client is not up to date with the latest changes in the OpenAPI specification. |
This comment has been minimized.
This comment has been minimized.
3c70b29
to
a0b226f
Compare
The generated OpenAPI client is not up to date with the latest changes in the OpenAPI specification. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1866 +/- ##
==========================================
+ Coverage 84.45% 84.60% +0.15%
==========================================
Files 197 203 +6
Lines 6554 6691 +137
Branches 730 742 +12
==========================================
+ Hits 5535 5661 +126
- Misses 858 866 +8
- Partials 161 164 +3 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
a0b226f
to
9a12b6c
Compare
The generated OpenAPI client is not up to date with the latest changes in the OpenAPI specification. |
This comment has been minimized.
This comment has been minimized.
f4c4864
to
7033a8f
Compare
This comment has been minimized.
This comment has been minimized.
7033a8f
to
0dc77d0
Compare
This comment has been minimized.
This comment has been minimized.
7dd9109
to
61cfa05
Compare
The generated OpenAPI client is not up to date with the latest changes in the OpenAPI specification. |
This comment has been minimized.
This comment has been minimized.
The generated OpenAPI client is not up to date with the latest changes in the OpenAPI specification. |
This comment has been minimized.
This comment has been minimized.
61cfa05
to
9524c73
Compare
The generated OpenAPI client is not up to date with the latest changes in the OpenAPI specification. |
This comment has been minimized.
This comment has been minimized.
9524c73
to
d0feba1
Compare
This comment has been minimized.
This comment has been minimized.
frontend/src/app/settings/modelsources/t4c-settings/t4c-settings.component.html
Outdated
Show resolved
Hide resolved
d0feba1
to
02517c9
Compare
This comment has been minimized.
This comment has been minimized.
02517c9
to
e805c31
Compare
Until now, T4C instances had a field for setting up a license server. This was a problem because setting up multiple instances meant inputting duplicate license server details. Now, users create a license server and link it to one or more instances.
This comment has been minimized.
This comment has been minimized.
e805c31
to
1b87f79
Compare
Quality Gate passedIssues Measures |
This report was generated by comparing 3484369 with 352a1cb. ArtifactName:
|
item | count |
---|---|
pass | 298 |
change | 12 |
new | 8 |
delete | 0 |
📝 Report
Differences
Settings Components_Modelsources_T4C_Server Instance_Add Instance_desktop.png
actual | |
---|---|
expected | |
difference |
Settings Components_Modelsources_T4C_Server Instance_Add Instance_mobile.png
actual | |
---|---|
expected | |
difference |
Settings Components_Modelsources_T4C_Server Instance_Archived Instance_desktop.png
actual | |
---|---|
expected | |
difference |
Settings Components_Modelsources_T4C_Server Instance_Archived Instance_mobile.png
actual | |
---|---|
expected | |
difference |
Settings Components_Modelsources_T4C_Server Instance_Edit Existing Instance_desktop.png
actual | |
---|---|
expected | |
difference |
Settings Components_Modelsources_T4C_Server Instance_Edit Existing Instance_mobile.png
actual | |
---|---|
expected | |
difference |
Settings Components_Modelsources_T4C_Server Instance_Existing Instance_desktop.png
actual | |
---|---|
expected | |
difference |
Settings Components_Modelsources_T4C_Server Instance_Existing Instance_mobile.png
actual | |
---|---|
expected | |
difference |
Settings Components_Modelsources_T4C_Server Overview_Loading_desktop.png
actual | |
---|---|
expected | |
difference |
Settings Components_Modelsources_T4C_Server Overview_Loading_mobile.png
actual | |
---|---|
expected | |
difference |
Settings Components_Modelsources_T4C_Server Overview_Overview_desktop.png
actual | |
---|---|
expected | |
difference |
Settings Components_Modelsources_T4C_Server Overview_Overview_mobile.png
actual | |
---|---|
expected | |
difference |
Until now, T4C instances had a field for setting up a license server. This was a problem because
setting up multiple instances meant inputting duplicate license server details. Now, users create a
license server and link it to one or more instances.
Breaking Changes
/api/v1/settings/modelsources/t4c
were modified and split into different routes for license servers and T4C server instances. Make sure to update your scripts accordingly.