Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Disable OpenAPI options via CLI arguments #1896

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

MoritzWeber0
Copy link
Member

Before, it was inconsistenly handled via environment variables and a postprocess script.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.69%. Comparing base (874a04f) to head (ea3c22e).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
backend/capellacollab/cli/openapi.py 86.36% 0 Missing and 3 partials ⚠️
backend/capellacollab/core/responses.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1896   +/-   ##
=======================================
  Coverage   84.69%   84.69%           
=======================================
  Files         203      203           
  Lines        6691     6712   +21     
  Branches      457      465    +8     
=======================================
+ Hits         5667     5685   +18     
  Misses        866      866           
- Partials      158      161    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 10, 2024

A Storybook preview is available for commit 9349312.
➡️ View Storybook
➡️ View Chromatic build

This comment has been minimized.

Before, it was inconsistenly handled via environment variables
and a postprocess script.
@MoritzWeber0 MoritzWeber0 force-pushed the refactor-openapi-postprocessing branch from cacca7c to ea3c22e Compare October 10, 2024 12:06
Copy link

sonarcloud bot commented Oct 10, 2024

Copy link

This report was generated by comparing 9349312 with 874a04f.
If you would like to check difference, please check here.

success

ArtifactName: reg

✨✨ That's perfect, there is no visual difference! ✨✨

item count
pass 340
change 0
new 0
delete 0

@MoritzWeber0 MoritzWeber0 merged commit ecf5fff into main Oct 10, 2024
31 of 32 checks passed
@MoritzWeber0 MoritzWeber0 deleted the refactor-openapi-postprocessing branch October 10, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant