fix: Increase connection pool to 20 concurrent database connections #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Changelog 4.8.3.dev9+gd863e2da |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1924 +/- ##
=======================================
Coverage 84.68% 84.68%
=======================================
Files 206 206
Lines 6739 6739
Branches 463 463
=======================================
Hits 5707 5707
Misses 870 870
Partials 162 162 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
Due to the asynchronous nature of FastAPI and the number of requests, it can happen that we have to handle more than the default of 5 requests at the same time. In addition, reduce the pool timeout to 5. The goal is to fail requests if they can't get a database session within 5 seconds instead of spawning a queue with wait times of 30 seconds, which can lead to a blocking backend.
MoritzWeber0
force-pushed
the
pool-size
branch
from
561c66c to
ce5cb51
Compare
|
|
This report was generated by comparing d863e2d with 7963611. ArtifactName:
|
| item | count |
|---|---|
| pass | 340 |
| change | 2 |
| new | 0 |
| delete | 0 |
📝 Report
Differences
Session Components_Feedback_One Session With User Information_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Feedback_Rating Selected_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the asynchronous nature of FastAPI and the number of requests, it can happen that we have to handle more than the default of 5 requests at the same time.
In addition, reduce the pool timeout to 5. The goal is to fail requests if they can't get a database session within 5 seconds instead of spawning a queue with wait times of 30 seconds, which can lead to a blocking backend.
Resolves #1914