chore: Enable pylint in tests folder #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Changelog 4.10.1.dev4+ge7aa146d |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1933 +/- ##
=======================================
Coverage 84.80% 84.80%
=======================================
Files 211 211
Lines 6875 6875
Branches 472 472
=======================================
Hits 5830 5830
Misses 879 879
Partials 166 166 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Enable pylint in the tests folder. The pylint-pytest plugin is used to prevent false-positives for fixtures. There are still some false-positives for unused arguments in methods and classes that we mock, so corresponding comments to ignore these errors are added. This was also used to fix some valid issues that pylint found (like duplicate and unnecessary imports). Closes #544
|
MoritzWeber0
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable pylint in the tests folder. The pylint-pytest plugin is used to prevent false-positives for fixtures. There are still some false-positives for unused arguments in methods and classes that we mock, so corresponding comments to ignore these errors are added. This was also used to fix some valid issues that pylint found (like duplicate and unnecessary imports).
Closes #544