Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove references to nightly run at 3am UTC #1965

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

MoritzWeber0
Copy link
Member

The timezone and cron schedule are configurable.
Remove all hardcoded references to the old time.

Thanks @ewuerger for reporting.

The timezone and cron schedule are configurable.
Remove all hardcoded references to the old time.
@MoritzWeber0 MoritzWeber0 requested a review from ewuerger November 6, 2024 13:52
Copy link

sonarcloud bot commented Nov 6, 2024

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.90%. Comparing base (76136c0) to head (1939393).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1965   +/-   ##
=======================================
  Coverage   84.90%   84.90%           
=======================================
  Files         211      211           
  Lines        6909     6909           
  Branches      476      476           
=======================================
  Hits         5866     5866           
  Misses        879      879           
  Partials      164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 6, 2024

A Storybook preview is available for commit 492d94c.
➡️ View Storybook
➡️ View Chromatic build

Copy link

github-actions bot commented Nov 6, 2024

This report was generated by comparing 492d94c with 76136c0.
If you would like to check difference, please check here.

change detected

ArtifactName: reg

item count
pass 344
change 6
new 0
delete 0
📝 Report

Differences

Pipeline Components_Create Backup_Request Sent_desktop.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Create Backup_Request Sent_mobile.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Create Backup_With Linked Models_desktop.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Create Backup_With Linked Models_mobile.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Trigger Pipeline_Pipeline Overview_desktop.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Trigger Pipeline_Pipeline Overview_mobile.png

actual Actual
expected Expected
difference Difference

Copy link
Member

@ewuerger ewuerger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MoritzWeber0 MoritzWeber0 merged commit 3c5c1fd into main Nov 6, 2024
29 checks passed
@MoritzWeber0 MoritzWeber0 deleted the remove-nightly-references branch November 6, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants