feat: Allow setting project type during creation #1967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1967 +/- ##
=======================================
Coverage 84.75% 84.76%
=======================================
Files 211 211
Lines 6922 6923 +1
Branches 478 478
=======================================
+ Hits 5867 5868 +1
Misses 890 890
Partials 165 165 ☔ View full report in Codecov by Sentry. |
API Changelog 4.11.1.dev8+g7d63ee40POST /api/v1/projects
|
|
A Storybook preview is available for commit 7d63ee4. |
This comment has been minimized.
This comment has been minimized.
MoritzWeber0
requested changes
Nov 7, 2024
frontend/src/app/projects/create-project/create-project.component.html
Outdated
Show resolved
Hide resolved
zusorio
force-pushed
the
set-project-type-during-creation
branch
from
e3be987 to
a1e8dba
Compare
This comment has been minimized.
This comment has been minimized.
MoritzWeber0
reviewed
Nov 7, 2024
zusorio
force-pushed
the
set-project-type-during-creation
branch
from
a1e8dba to
38502a3
Compare
This comment has been minimized.
This comment has been minimized.
zusorio
force-pushed
the
set-project-type-during-creation
branch
from
38502a3 to
e66ef12
Compare
zusorio
force-pushed
the
set-project-type-during-creation
branch
from
e66ef12 to
9f7bb85
Compare
This comment has been minimized.
This comment has been minimized.
|
MoritzWeber0
approved these changes
Nov 7, 2024
|
This report was generated by comparing 7d63ee4 with e8cb5e1. ArtifactName:
|
| item | count |
|---|---|
| pass | 344 |
| change | 6 |
| new | 0 |
| delete | 0 |
📝 Report
Differences
Project Components_Create Project_Create Project_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Project Components_Create Project_Create Project_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Project Components_Project Details_Edit Project Metadata_General_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Project Components_Project Details_Edit Project Metadata_General_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Project Components_Project Details_Edit Project Metadata_With Title_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Project Components_Project Details_Edit Project Metadata_With Title_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1961