feat: Handle unready sessions in session viewer #1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1978 +/- ##
=======================================
Coverage 84.71% 84.71%
=======================================
Files 211 211
Lines 6995 6995
Branches 491 491
=======================================
Hits 5926 5926
Misses 906 906
Partials 163 163 ☔ View full report in Codecov by Sentry. |
|
A Storybook preview is available for commit a70c7ef. |
This comment has been minimized.
This comment has been minimized.
MoritzWeber0
force-pushed
the
session-viewer-auto-connect
branch
from
6f3db32 to
88fce58
Compare
This comment has been minimized.
This comment has been minimized.
zusorio
approved these changes
Nov 12, 2024
MoritzWeber0
force-pushed
the
session-viewer-auto-connect
branch
from
88fce58 to
848eb23
Compare
This comment has been minimized.
This comment has been minimized.
This enabled direct connection to the session viewer. Instead of a separate components to select sessions, it's no embedded into the "Active Sessions" view. This makes the session viewer more visible and requires less user interaction. Read-only sessions are now directly connected after creation. The Session Viewer shows the current status of the session and takes over the session refresh on it's own. Once the session is ready, it connects to it.
MoritzWeber0
force-pushed
the
session-viewer-auto-connect
branch
from
848eb23 to
107fe1d
Compare
|
|
This report was generated by comparing a70c7ef with 4fe9a8d. ArtifactName:
|
| item | count |
|---|---|
| pass | 298 |
| change | 48 |
| new | 12 |
| delete | 0 |
📝 Report
Differences
General Components_Header_Administrator_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
General Components_Header_Normal User_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
General Components_Version_First Time Accessed_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
General Components_Version_First Time Accessed_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
General Components_Version_New Version Available_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
General Components_Version_New Version Available_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Project Components_Project Details_Loading As Project Lead_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Project Components_Project Details_Loading As Project Lead_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Project Components_Project Details_Loading_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Project Components_Project Details_Loading_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Project Components_Project Metadata_Normal User Archived_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Project Components_Project Metadata_Normal User Archived_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Project Components_Project Metadata_Project Admin Archived_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Project Components_Project Metadata_Project Admin Archived_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Readonly Session Success State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Readonly Session Success State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Failed State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Failed State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Not Found State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Not Found State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Pending State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Pending State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Preparation Pending State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Preparation Pending State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Preparation Running State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Preparation Running State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Running State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Running State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Shared With User_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Shared With User_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Sharing Enabled_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Sharing Enabled_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Terminated State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Terminated State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Unknown State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Unknown State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session With Feedback Enabled_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session With Feedback Enabled_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Shared Session_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Shared Session_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Create Readonly Session Dialog_Max Number Of Models Exceeded_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Create Readonly Session Dialog_Max Number Of Models Exceeded_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Create Readonly Session Dialog_Model Selected And Start Session Possible_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Create Readonly Session Dialog_Model Selected And Start Session Possible_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Create Readonly Session Dialog_No Models To Show_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Create Readonly Session Dialog_No Models To Show_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Create Readonly Session Dialog_Show Note For Compatible Session_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Create Readonly Session Dialog_Show Note For Compatible Session_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
New Items
Session Components_Session Viewer_Loading_desktop.png
 |
Session Components_Session Viewer_Loading_mobile.png
 |
Session Components_Session Viewer_One Session Tiling Pending_desktop.png
 |
Session Components_Session Viewer_One Session Tiling Pending_mobile.png
 |
Session Components_Session Viewer_One Successful Session_desktop.png
 |
Session Components_Session Viewer_One Successful Session_mobile.png
 |
Session Components_Session Viewer_Two Sessions Floating_desktop.png
 |
Session Components_Session Viewer_Two Sessions Floating_mobile.png
 |
Session Components_Session Viewer_Two Sessions Tiling Pending_desktop.png
 |
Session Components_Session Viewer_Two Sessions Tiling Pending_mobile.png
 |
Session Components_Session Viewer_Two Sessions Tiling_desktop.png
 |
Session Components_Session Viewer_Two Sessions Tiling_mobile.png
 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enabled direct connection to the session viewer. Instead of a separate components to select sessions, it's no embedded into the "Active Sessions" view.
This makes the session viewer more visible and requires less user interaction.
Read-only sessions are now directly connected after creation.
The Session Viewer shows the current status of the session and takes over the session refresh on it's own. Once the session is ready, it connects to it.