Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve regex for API changelog generation #1985

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

MoritzWeber0
Copy link
Member

A hashtag following a number is detected as reference to an issue in GitHub. This breaks the API changelog comment and the regex replaced those references.

A hashtag following a number is detected as reference to an issue
in GitHub. This breaks the API changelog comment and the regex
replaced those references.
Copy link

sonarcloud bot commented Nov 13, 2024

Copy link

API Changelog 4.13.1.dev4+g82d17cba

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.58%. Comparing base (6156e34) to head (3067534).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1985   +/-   ##
=======================================
  Coverage   84.58%   84.58%           
=======================================
  Files         212      212           
  Lines        7032     7032           
  Branches      492      492           
=======================================
  Hits         5948     5948           
  Misses        924      924           
  Partials      160      160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This report was generated by comparing 82d17cb with 6156e34.
If you would like to check difference, please check here.

change detected

ArtifactName: reg

item count
pass 354
change 4
new 0
delete 0
📝 Report

Differences

Session Components_Feedback_One Session With User Information_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Feedback_One Session With User Information_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Feedback_Rating Selected_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Feedback_Rating Selected_mobile.png

actual Actual
expected Expected
difference Difference

@MoritzWeber0 MoritzWeber0 merged commit fb961e2 into main Nov 13, 2024
30 checks passed
@MoritzWeber0 MoritzWeber0 deleted the api-generation-fix-hyperlinks branch November 13, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant