feat: Remove floating window manager #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2020 +/- ##
=======================================
Coverage 84.62% 84.62%
=======================================
Files 212 212
Lines 7068 7068
Branches 493 493
=======================================
Hits 5981 5981
Misses 926 926
Partials 161 161 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
A Storybook preview is available for commit 74cb41f. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
I'd only remove it from the dropdown menu / remove the dropdown menu. It's still working and relevant - but not useful at the moment, but will get useful when it's possible to spawn sessions from the session viewer. In the tiling window manager it would automatically rearrange all existing windows, the floating window manager doesn't have the issue.
zusorio
force-pushed
the
remove-floating-window-manager
branch
from
1e7300b to
529ed95
Compare
This comment has been minimized.
This comment has been minimized.
Remove the option to spawn a session using the floating window manager and rework some of the UI surrounding it. Closes #2011
zusorio
force-pushed
the
remove-floating-window-manager
branch
from
529ed95 to
f4b615c
Compare
|
|
This report was generated by comparing 74cb41f with 3fbb0a1. ArtifactName:
|
| item | count |
|---|---|
| pass | 336 |
| change | 30 |
| new | 0 |
| delete | 0 |
📝 Report
Differences
Session Components_Active Sessions_Loading_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Loading_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_No Active Stories_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_No Active Stories_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Readonly Session Success State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Readonly Session Success State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Failed State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Failed State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Not Found State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Not Found State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Pending State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Pending State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Preparation Pending State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Preparation Pending State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Preparation Running State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Preparation Running State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Running State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Running State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Shared With User_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Shared With User_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Sharing Enabled_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Sharing Enabled_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Terminated State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Terminated State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Unknown State_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session Unknown State_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session With Feedback Enabled_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Session With Feedback Enabled_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Shared Session_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Session Components_Active Sessions_Shared Session_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
MoritzWeber0
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the floating window manager and redesign some of the surrounding UI.
Closes #2011