-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Move terminate button to end of session card #2030
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2030 +/- ##
=======================================
Coverage 85.46% 85.46%
=======================================
Files 225 225
Lines 7411 7411
Branches 513 513
=======================================
Hits 6334 6334
Misses 913 913
Partials 164 164 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
A Storybook preview is available for commit 660aa54. |
This report was generated by comparing 660aa54 with 5290f43. ArtifactName:
|
item | count |
---|---|
pass | 384 |
change | 28 |
new | 0 |
delete | 0 |
📝 Report
Differences
Session Components_Active Sessions_Readonly Session Success State_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Readonly Session Success State_mobile.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Failed State_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Failed State_mobile.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Not Found State_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Not Found State_mobile.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Pending State_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Pending State_mobile.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Preparation Pending State_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Preparation Pending State_mobile.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Preparation Running State_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Preparation Running State_mobile.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Running State_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Running State_mobile.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Shared With User Terminating Soon_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Shared With User Terminating Soon_mobile.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Shared With User_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Shared With User_mobile.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Sharing Enabled_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Sharing Enabled_mobile.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Terminated State_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Terminated State_mobile.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Terminating Soon_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Terminating Soon_mobile.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Unknown State_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session Unknown State_mobile.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session With Feedback Enabled_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_Active Sessions_Session With Feedback Enabled_mobile.png
actual | |
---|---|
expected | |
difference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Closes #2012