Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move terminate button to end of session card #2030

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

zusorio
Copy link
Member

@zusorio zusorio commented Nov 20, 2024

Closes #2012

Copy link

sonarcloud bot commented Nov 20, 2024

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.46%. Comparing base (5290f43) to head (9be2857).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2030   +/-   ##
=======================================
  Coverage   85.46%   85.46%           
=======================================
  Files         225      225           
  Lines        7411     7411           
  Branches      513      513           
=======================================
  Hits         6334     6334           
  Misses        913      913           
  Partials      164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

A Storybook preview is available for commit 660aa54.
➡️ View Storybook
➡️ View Chromatic build

Copy link

This report was generated by comparing 660aa54 with 5290f43.
If you would like to check difference, please check here.

change detected

ArtifactName: reg

item count
pass 384
change 28
new 0
delete 0
📝 Report

Differences

Session Components_Active Sessions_Readonly Session Success State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Readonly Session Success State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Failed State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Failed State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Not Found State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Not Found State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Pending State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Pending State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Preparation Pending State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Preparation Pending State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Preparation Running State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Preparation Running State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Running State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Running State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Shared With User Terminating Soon_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Shared With User Terminating Soon_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Shared With User_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Shared With User_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Sharing Enabled_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Sharing Enabled_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Terminated State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Terminated State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Terminating Soon_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Terminating Soon_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Unknown State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Unknown State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session With Feedback Enabled_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session With Feedback Enabled_mobile.png

actual Actual
expected Expected
difference Difference

Copy link
Member

@MoritzWeber0 MoritzWeber0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MoritzWeber0 MoritzWeber0 merged commit 2851dcf into main Nov 20, 2024
29 checks passed
@MoritzWeber0 MoritzWeber0 deleted the terminate-at-ed branch November 20, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Terminate button to the end in the Active Sessions
2 participants