Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle long filenames in file browser on mobile devices #2048

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

MoritzWeber0
Copy link
Member

Long filenames messed up the layout on mobile devices.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.46%. Comparing base (eda22af) to head (c6860ef).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2048   +/-   ##
=======================================
  Coverage   85.46%   85.46%           
=======================================
  Files         225      225           
  Lines        7412     7412           
  Branches      513      513           
=======================================
  Hits         6335     6335           
  Misses        913      913           
  Partials      164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

Copy link

github-actions bot commented Nov 29, 2024

A Storybook preview is available for commit b74fe70.
➡️ View Storybook
➡️ View Chromatic build

@MoritzWeber0 MoritzWeber0 force-pushed the file-browser-large-filenames branch from 50fa776 to c9a16cf Compare November 29, 2024 16:11

This comment has been minimized.

@MoritzWeber0 MoritzWeber0 requested a review from zusorio November 29, 2024 16:32
@MoritzWeber0 MoritzWeber0 force-pushed the file-browser-large-filenames branch from c9a16cf to b002e8d Compare December 2, 2024 09:29

This comment has been minimized.

Long filenames messed up the layout on mobile devices.
@MoritzWeber0 MoritzWeber0 force-pushed the file-browser-large-filenames branch from b002e8d to c6860ef Compare December 2, 2024 09:39
Copy link

sonarcloud bot commented Dec 2, 2024

Copy link

github-actions bot commented Dec 2, 2024

This report was generated by comparing b74fe70 with eda22af.
If you would like to check difference, please check here.

change detected

ArtifactName: reg

item count
pass 402
change 10
new 0
delete 0
📝 Report

Differences

Session Components_File Browser_Download Preparation_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_File Browser_Download Preparation_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_File Browser_Files_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_File Browser_Files_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_File Browser_Upload In Progress_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_File Browser_Upload In Progress_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_File Browser_Upload New File_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_File Browser_Upload New File_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_File Browser_Upload Processed By Backend_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_File Browser_Upload Processed By Backend_mobile.png

actual Actual
expected Expected
difference Difference

@MoritzWeber0 MoritzWeber0 merged commit 2d79dbf into main Dec 2, 2024
29 checks passed
@MoritzWeber0 MoritzWeber0 deleted the file-browser-large-filenames branch December 2, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants