Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(frontend): Add support for analog.js framework #2051

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

MoritzWeber0
Copy link
Member

@MoritzWeber0 MoritzWeber0 commented Nov 30, 2024

The main advantage of analog.js is support for file-based routing, which helps structuring the components in the frontend. In addition, it supports Astro.

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.47%. Comparing base (b138d68) to head (335bc8a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2051   +/-   ##
=======================================
  Coverage   85.47%   85.47%           
=======================================
  Files         224      224           
  Lines        7399     7399           
  Branches      513      513           
=======================================
  Hits         6324     6324           
  Misses        911      911           
  Partials      164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MoritzWeber0 MoritzWeber0 force-pushed the analog-js branch 4 times, most recently from 49f16ea to 88a1e44 Compare December 6, 2024 15:13
@MoritzWeber0 MoritzWeber0 marked this pull request as ready for review December 6, 2024 15:16

This comment has been minimized.

Copy link

github-actions bot commented Dec 7, 2024

A Storybook preview is available for commit eef2cf2.
➡️ View Storybook
➡️ View Chromatic build

This comment has been minimized.

@MoritzWeber0 MoritzWeber0 requested a review from zusorio December 9, 2024 09:50
frontend/src/app/general/metadata/metadata.service.ts Outdated Show resolved Hide resolved
frontend/vite-env.d.ts Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Dec 9, 2024

API Changelog 4.14.1.dev34+geef2cf27

This comment has been minimized.

This comment has been minimized.

The main advantage of analog.js is support for file-based
routing, which helps structuring the components in the frontend.
Copy link

sonarcloud bot commented Dec 9, 2024

Copy link

github-actions bot commented Dec 9, 2024

This report was generated by comparing eef2cf2 with b138d68.
If you would like to check difference, please check here.

success

ArtifactName: reg

✨✨ That's perfect, there is no visual difference! ✨✨

item count
pass 422
change 0
new 0
delete 0

@MoritzWeber0 MoritzWeber0 merged commit f251d4c into main Dec 9, 2024
32 checks passed
@MoritzWeber0 MoritzWeber0 deleted the analog-js branch December 9, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants