Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Auto-select sessions in active session overview #2057

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

MoritzWeber0
Copy link
Member

Often users only have one or two sessions and it's faster to unselect the sessions that are not needed.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.46%. Comparing base (f4b33e5) to head (5f9c44d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2057   +/-   ##
=======================================
  Coverage   85.46%   85.46%           
=======================================
  Files         225      225           
  Lines        7412     7412           
  Branches      513      513           
=======================================
  Hits         6335     6335           
  Misses        913      913           
  Partials      164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 2, 2024

A Storybook preview is available for commit 81b8ef6.
➡️ View Storybook
➡️ View Chromatic build

Often users only have one or two sessions and it's faster to
unselect the sessions that are not needed.
Copy link

sonarcloud bot commented Dec 2, 2024

This comment has been minimized.

Copy link

github-actions bot commented Dec 2, 2024

This report was generated by comparing 81b8ef6 with f4b33e5.
If you would like to check difference, please check here.

change detected

ArtifactName: reg

item count
pass 382
change 30
new 0
delete 0
📝 Report

Differences

Session Components_Active Sessions_Readonly Session Success State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Readonly Session Success State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Failed State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Failed State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Not Found State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Not Found State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Pending State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Pending State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Preparation Pending State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Preparation Pending State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Preparation Running State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Preparation Running State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Running State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Running State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Shared With User Terminating Soon_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Shared With User Terminating Soon_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Shared With User_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Shared With User_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Sharing Enabled_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Sharing Enabled_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Terminated State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Terminated State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Terminating Soon_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Terminating Soon_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Unknown State_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session Unknown State_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session With Feedback Enabled_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Session With Feedback Enabled_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Shared Session_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Active Sessions_Shared Session_mobile.png

actual Actual
expected Expected
difference Difference

@MoritzWeber0 MoritzWeber0 merged commit b81c92c into main Dec 2, 2024
30 checks passed
@MoritzWeber0 MoritzWeber0 deleted the auto-select-sessions branch December 2, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants