Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting of tags on books #37

Closed
Mifgan opened this issue Mar 5, 2023 · 3 comments
Closed

Sorting of tags on books #37

Mifgan opened this issue Mar 5, 2023 · 3 comments
Assignees
Labels
Feature Feature request

Comments

@Mifgan
Copy link

Mifgan commented Mar 5, 2023

Currently when you add a bunch of tags to a book (I did mine by bulk edit) it adds them seemingly randomly.
In this case, for the first group: I added them in this order:

  • 7th Sea
  • 1e
  • Fantasy
  • Swashbuckling / Pirates
  • Primarily D10
  • Roll and Keep
  • Point Based

The order on which they appeared on the books is:

  • 7th Sea
  • Fantasy
  • Point Based
  • Roll and Keep
  • 1e
  • Swashbuckling / Pirates
  • Primarily D10

For the second batch it changed it to the same order, but I saw I forgot to add the 7th Sea tag. When I added in a second edit, it stayed at the end.

afbeelding

Suggestion:

  • All tags appear in a fixed alphabetical order.
  • Prefered An option in the settings to choose the order the tags appear, ie. alphabetically (general), alphabetically (by tag group and tag tree).
    In the latter case, in the above example the order would be: 7th Sea, 1e, Swashbuckling / Pirates as Action / Adventure is before Fantasy, Fantasy, Primarily D10 as Dice is before Point Based, Point Based, Roll and Keep.
@Mifgan Mifgan added the Feature Feature request label Mar 5, 2023
@Mifgan
Copy link
Author

Mifgan commented Mar 5, 2023

Peculiar, on restarting the application the order of the second group (the 7th Sea 2e books), the order of the tags changed to mirror the others.

afbeelding

@DSPaul
Copy link
Owner

DSPaul commented Mar 8, 2023

I chose to order them by what I found the most intuitive option: the same order as they appear in your tree of tags, top to bottom if you were to remove the indentations (also known as pre order depth first search) . This way they are all nicely grouped and they follow your preferred order within a group.

@Mifgan
Copy link
Author

Mifgan commented Mar 8, 2023

Thanks! That's perfect!

@DSPaul DSPaul closed this as completed in 298abb1 Mar 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature request
Projects
Status: Released
Development

No branches or pull requests

2 participants