Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local Docker test script: switch parameter to always delete/recreate container before copying #30

Open
DTW-DanWard opened this issue Sep 20, 2017 · 1 comment

Comments

@DTW-DanWard
Copy link
Owner

Rather than re-copying over preexisting content on a container, delete the container and recreate each time if user passes switch param.

If performance tests are good, rather than specifying param, could make delete/recreate the default. Downside is if user is also connected to container (manually poking about, running tests, etc.), stopping and deleting container might not be a wise.... could prompt user...?

@DTW-DanWard
Copy link
Owner Author

Also, delete container before attempting to copy rather than at end; if an error occurs during testing want to leave container there so can be reviewed for issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant