Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong % rep amounts #478

Open
AugustoL opened this issue Jan 2, 2023 · 2 comments
Open

Wrong % rep amounts #478

AugustoL opened this issue Jan 2, 2023 · 2 comments

Comments

@AugustoL
Copy link
Member

AugustoL commented Jan 2, 2023

Description
Wrong % of REP in actions

On a proposal in dxgov guild in gnosis: https://qa.projectdavi.eth.limo/#/gnosis/0x3f842726188FcD932d43bcA291be28138228e6D9/proposal/0x00514250dbe1f619f4adcc6b90f47be899d5a36bee900d2754c2b4e1dd5ee7f5

image

Steps to Reproduce
(https://qa.projectdavi.eth.limo/#/gnosis/0x3f842726188FcD932d43bcA291be28138228e6D9/proposal/0x00514250dbe1f619f4adcc6b90f47be899d5a36bee900d2754c2b4e1dd5ee7f5)

Device Information

  • OS: Ubuntu
  • Browser brave
  • Version 1.46
@rossneilson
Copy link
Contributor

Yep, unfortunately, we deployed the first guilds with rep not transformed to wei. And the maths is interpreting it as infinite instead of a very very large amount more (10^18). Going to close this since displaying it as a factor isn't much better than infinite

@AugustoL
Copy link
Member Author

AugustoL commented Jan 3, 2023

First we should show the absolute amount of REP, and then if the % is not infinity, we should show it as well. This way at least I can see "2000 REP minted to x account"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AugustoL @rossneilson