Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Subject Alternative Names #22

Closed
Muffinman opened this issue Aug 3, 2022 · 3 comments
Closed

[Feature Request] Subject Alternative Names #22

Muffinman opened this issue Aug 3, 2022 · 3 comments

Comments

@Muffinman
Copy link
Contributor

Muffinman commented Aug 3, 2022

Hi,

I'm wondering if this package supports sending SubjectAlternativeNames to LetsEncrypt / AcmePHP?

I can see that AcmePHP itself does have support for them, but I couldn't see any obvious references in this package.

EDIT: Our use case is for a multi-tenant Laravel application. we want one vhost per tenant rather than one per domain, so it makes sense to have a single SSL cert with all their active domains contained inside.

@Daanra
Copy link
Owner

Daanra commented Aug 5, 2022

It currently does not support SubjectAlternativeNames but this should be rather easy to implement.

I can probably release this in a couple of days.

@Daanra Daanra changed the title Does this package support Subject Alternative Names? [Feature Request] Subject Alternative Names Aug 5, 2022
@Muffinman
Copy link
Contributor Author

That sounds excellent! Happy to send a PR or collaborate on this if it makes sense.

I did take a look but I couldn't see any way of doing it without breaking changes. I think it will need new parameters adding to methods.

@Daanra
Copy link
Owner

Daanra commented Sep 16, 2022

Feature added to v0.5.0

@Daanra Daanra closed this as completed Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants