Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the M2M for Works #119

Open
Neraste opened this issue Jan 12, 2020 · 0 comments
Open

Remove the M2M for Works #119

Neraste opened this issue Jan 12, 2020 · 0 comments
Labels
refactor Make things more beautiful inside, but same outside

Comments

@Neraste
Copy link
Member

Neraste commented Jan 12, 2020

The M2M relationship using a custom intermediary object is too confuse. It leads to a weird access to works in a song JSON representation:

{
  "works": [
    {
      "work": {},
    }
  ]
}

The intermediate object is not a real object, so its name is sometimes hard to understand, e.g. songworklink_set.

Instead, we should use a real WorkLink object with two FKs.

@Neraste Neraste added the refactor Make things more beautiful inside, but same outside label Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Make things more beautiful inside, but same outside
Projects
None yet
Development

No branches or pull requests

1 participant