Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window reopens if one clicks at the very top of the icon #101

Closed
samcarter opened this issue Feb 3, 2023 · 6 comments
Closed

Window reopens if one clicks at the very top of the icon #101

samcarter opened this issue Feb 3, 2023 · 6 comments

Comments

@samcarter
Copy link

(thank you very much for creating this very handy app, it is really convenient to have one's reminders available in the menu bar!)

If the Reminders Menu Bar window is open and one clicks on the icon again, the window closes. That's expected behaviour and matches the behaviour of many other menu bar apps.

However there is a literal edge case: if one clicks at the very top of the icon, the window seems to close, but reopens immediately.

Here a short screen recording to demonstrate this behaviour:

2023-02-03.12-59-46.mp4

Reminders Menu Bar version: 1.13.0
macOS: 11.7.2

@DamascenoRafael
Copy link
Owner

Hi @samcarter. Thanks for your feedback :)
This really wasn't expected, but it's weird at the same time, hahaha.

Investigating the popover notifications (via NotificationCenter) and the moment the togglePopover() function is called I came to the following conclusions:

When clicking to open the sequence of events is always the same:

  1. togglePopover function
  2. popover will show notification
  3. popover did show notification

When clicking in the center of the button to close the popover:

  1. popover will close notification
  2. popover did close notification

For some reason the togglePopover function is not even called in this case.

When clicking in the top of the button to close the popover:

  1. popover will close notification
  2. popover did close notification
  3. togglePopover function -- but at that moment the popover is already closed so the function opened it again

I couldn't figure out why this was happening. But I'm testing a way to work around this problem.

@samcarter
Copy link
Author

@DamascenoRafael Thanks for having a look at this!

@DamascenoRafael
Copy link
Owner

@samcarter please let me know if the behavior is as expected in v1.16.0 📦

@samcarter
Copy link
Author

@DamascenoRafael The new version works beautifully! Thanks a lot!

(previously, I was switching back for some things to the mac app, but ever since you added the default date, I not once had to open the mac reminders app and could do everything just with your app, it is really handy!)

@samcarter
Copy link
Author

@DamascenoRafael Just in case you get any reports: after updating to v1.16.0 I once had to re-do some setting, like allowing the app access to my calenders, moving it to previous position in my menu bar etc. I suspect that's because the app is now signed and mac essential threats it as different app than before. Everything works fine, just in case you get any related reports about this.

@DamascenoRafael
Copy link
Owner

@samcarter I'm glad that you are enjoying the app 🥳
Please feel free to send new feedbacks or suggestions that may improve the app!!

About the need to redo some settings, thanks for letting me know. This could be due to the app's Bundle-id being renamed in v1.16.0. It should not occur in future versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants