Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click to edit #103

Closed
jeremybagel opened this issue Feb 7, 2023 · 4 comments
Closed

Click to edit #103

jeremybagel opened this issue Feb 7, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@jeremybagel
Copy link

I know this is kind of covered by the 3 dot contextual menu but the "normal" behaviour I'd expect would be to click to edit (I do this all the time) so find myself clicking at the reminder without being able to. Probably an enhancement rather than a bug but it would be rather helpful.

@DamascenoRafael DamascenoRafael added the enhancement New feature or request label May 7, 2023
@DamascenoRafael
Copy link
Owner

Hi @jeremybagel. Thanks for the feedback.
In Apple Reminders, text behaves like a textfield, but there are some issues with this approach.
I was thinking that when clicking on the reminder text the editing screen could open with the text in focus to be edited.

Let me know what you think about this solution:

Screen.Recording.2023-05-07.at.13.32.48.mp4

@jeremybagel
Copy link
Author

That works for me! What are the issues with editing it in situ?

@DamascenoRafael
Copy link
Owner

Great! We might rethink in the future the option to edit the reminder directly in the list.

Some issues that I remember that should be addressed in this approach:

  • In a previous attempt (Solving issue #27 edit reminder when tap on text #82) the textfield in macOS Monterey had a different background than in more recent versions of macOS. Would need to investigate to make the background transparent on all supported versions of macOS.
  • It would be necessary to check whether using multiple textfields instead of texts would affect performance when many items are displayed.
  • It would be necessary to manage textfields edits to save the changes. Waiting for the user to press return for exemple could cause multiple textfields to be in an edit state without the changes being saved at the same time.

@jeremybagel
Copy link
Author

jeremybagel commented May 9, 2023

If I may:

  1. Seems reasonable.
  2. Seems like a feat that can be easily overcome.
  3. The return or click out is an auto save. Multiple edits wouldn’t be an option since any single edit automatically commits. (It’s not a thousand word dissertation, any commits should be happily resolved.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants