Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide empty lists #4

Closed
scottrobertson opened this issue Jan 19, 2021 · 7 comments
Closed

Hide empty lists #4

scottrobertson opened this issue Jan 19, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@scottrobertson
Copy link
Contributor

When a list has no items in it, things look a bit odd as there is just a random title there. It would be good to hide lists have have no tasks in them.

@DamascenoRafael DamascenoRafael added the enhancement New feature or request label Jan 20, 2021
@DamascenoRafael
Copy link
Owner

That's a good point!

What do you think of showing a text below saying that the list has no reminders? So the changes in #5 will still allow a button to exist next to the title to define that the next reminder will be saved in the empty list.

It is always possible to hide a list through the filter button in the lower left corner of the app.

@scottrobertson
Copy link
Contributor Author

If you think the changes in #5 make sense, then yeah showing "List is empty" or something is a good idea 👍

@DamascenoRafael
Copy link
Owner

I used the same texts used by Apple Reminders.

So the message is different depending on whether the list has no items or if all items are completed (and only the uncompleted items are being displayed).

Screen Shot 2021-01-21 at 22 01 34

@scottrobertson
Copy link
Contributor Author

scottrobertson commented Jan 22, 2021 via email

@DamascenoRafael
Copy link
Owner

I couldn't decide. Does the left alignment seem more expected?

Screen Shot 2021-01-21 at 22 47 38

@scottrobertson
Copy link
Contributor Author

scottrobertson commented Jan 22, 2021

I couldn't decide. Does the left alignment seem more expected?

Screen Shot 2021-01-21 at 22 47 38

I think that looks a lot better yeah :)

@DamascenoRafael
Copy link
Owner

Great!! I'll close with a commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants