Audit tables column diffs type unexpectedly changed from JSON to TEXT

[pniep]

Hi @DamienHarper,

After update doctrine wants to change type of all diffs columns in audit tables from json to text. [db: postgres, json support: yes]
I'm not sure that was intended.

Fragment below forces TEXT as the type of all JSON columns when database actually supports json columns .

auditor/src/Provider/Doctrine/Persistence/Schema/SchemaManager.php

Line 192 in adc9fa1

if (DoctrineHelper::getDoctrineType('JSON') === $struct['type'] && $isJsonSupported) {

if (DoctrineHelper::getDoctrineType('JSON') === $struct['type'] && $isJsonSupported) {
    $type = DoctrineHelper::getDoctrineType('TEXT');
} else {
    $type = $struct['type'];
}

It looks like a bug. As commit message for these lines says the intent was to add compatibility for older versions of mariadb that don't support json.

[DamienHarper]

@pniep thanks for the feedback.
In order to ease debugging/investigation, could you please provide me your current

• PHP version
• database type and version
• auditor version

[dappa]

I have the same problem. I suspect the problem is the check for $isJsonSupported should be !$isJsonSupported as the fallback to TEXT is for those who do not support json.

auditor/src/Provider/Doctrine/Persistence/Schema/SchemaManager.php

Line 192 in adc9fa1

if (DoctrineHelper::getDoctrineType('JSON') === $struct['type'] && $isJsonSupported) {

[DamienHarper]

@dappa thanks for the feedback, looks like a bug. As I asked to @pniep, would you mind providing me your current

• PHP version
• database type and version
• auditor version

[pniep]

@DamienHarper
PHP 8.0.12
PostgreSQL 13.2
auditor 1.3
auditor-bundle 4.2

doctrine/orm 2.10.1
doctrine/dbal 2.13.4

[dappa]

@DamienHarper
PHP 7.4.3
mysql Ver 8.0.26
auditor 1.30

[dappa]

Any chance to revisit this issue?
It seems to be present on 2.0.5 still.

[DamienHarper]

@dappa @pniep Fixed in master and 2.4.7.
Sorry it took so long.