New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why making so much public -> encapsulation is needed #2

Open

yannicklamprecht opened this issue Jan 16, 2019 · 1 comment

Assignees

Labels

improvement needed

yannicklamprecht commented Jan 16, 2019

You are making to much public accessible. I recommend encapsulating the Attributes so not everything can interact with them.

DarkEyeDragon self-assigned this

DarkEyeDragon added the improvement needed label

Owner

DarkEyeDragon commented Jan 17, 2019

I'll probably do this at some point. This whole project is more a proof of concept rather than a functional app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment