isDynamic() returns always true even if MPD has changed its type from dynamic to static

[tomraut]

Environment

• The MPD passes the DASH-IF Conformance Tool on https://conformance.dashif.org/
• The stream has correct Access-Control-Allow-Origin headers (CORS)
• There are no network errors such as 404s in the browser console when trying to play the stream
• The issue observed is not mentioned on https://github.com/Dash-Industry-Forum/dash.js/wiki/FAQ
• The issue occurs in the latest reference client on http://reference.dashif.org/dash.js/ and not just on my page

• Link to playable MPD file: -
• Dash.js version: 3.1.3
• Browser name/version: Chrome 86.0.4240.111
• OS name/version: OSX Mojave 10.14.6

Steps to reproduce

Start to play live stream and at some point update MPD's type from dynamic into static.

Observed behaviour

Player keeps playing stream fine to very end but it is not possible to detect if stream is still live or ondemand as calling for isDynamic() method returns always "true". Also, suggestion from @dsilhavy in Slack to listen for DYNAMIC_STREAM_COMPLETED event does not work as that event is described to be internal one and not being exposed to MediaPlayer level.

[tomraut]

Some more information: Also this suggested way of hooking up to this event didn't work:

player.on('dynamicStreamCompleted',() => {
    console.log('completed');
})

I even tried adding breakpoint to ManifestUpdater where "eventBus.trigger(Events.DYNAMIC_STREAM_COMPLETED)" is executed and that breakpoint did hit when MPD's type changed to static, but event listeners didn't.

[bbert]

DYNAMIC_STREAM_COMPLETED is not (yet) public. See issue #3383 As proposed we can make it public and also rename it (DYNAMIC_TO_STATIC) as I suggested

[dsilhavy]

@tomraut #3444 introduced the media player event DYNAMIC_TO_STATIC. Please test and close this issue if it solves your problem

[tomraut]

@dsilhavy I've tested that one yesterday and can confirm that it solved issue.