Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCD requests via query-string end with a superfluous comma #3738

Closed
5 tasks done
mgreve-akamai opened this issue Aug 25, 2021 · 1 comment
Closed
5 tasks done

CMCD requests via query-string end with a superfluous comma #3738

mgreve-akamai opened this issue Aug 25, 2021 · 1 comment
Assignees
Labels
Milestone

Comments

@mgreve-akamai
Copy link

Environment
Steps to reproduce

Play the stream on the CMCD sample page: https://reference.dashif.org/dash.js/nightly/samples/advanced/cmcd.html

Observed behavior

All CMCD requests ends with a superfluous comma. Here's one example with the superfluous comma highlighted: https://dash.akamaized.net/akamai/bbb_30fps/bbb_30fps_480x270_600k/bbb_30fps_480x270_600k_1.m4v?CMCD=bl%3D0%2Cbr%3D759%2Ccid%3D%2221cf726cfe3d937b5f974f72bb5bd06a%22%2Cd%3D4000%2Cdl%3D0%2Cnor%3D%22%2Fakamai%2Fbbb_30fps%2Fbbb_30fps_480x270_600k%2Fbbb_30fps_480x270_600k_2.m4v%22%2Cot%3D%22v%22%2Crtp%3D30400%2Csf%3D%22d%22%2Csid%3D%22b248658d-1d1a-4039-91d0-8c08ba597da5%22%2Cst%3D%22v%22%2Csu%2Ctb%3D14932**%2C**

Here's the decoded variant:
https://dash.akamaized.net/akamai/bbb_30fps/bbb_30fps_480x270_600k/bbb_30fps_480x270_600k_1.m4v?CMCD=bl=0,br=759,cid="21cf726cfe3d937b5f974f72bb5bd06a",d=4000,dl=0,nor="/akamai/bbb_30fps/bbb_30fps_480x270_600k/bbb_30fps_480x270_600k_2.m4v",ot="v",rtp=30400,sf="d",sid="b248658d-1d1a-4039-91d0-8c08ba597da5",st="v",su,tb=14932,

The last %2C% (comma) part is not needed.

Console output

Irrelevant

Expected behavior

The comma is not needed.

@dsilhavy dsilhavy self-assigned this Aug 25, 2021
@dsilhavy dsilhavy added this to the 4.1.0 milestone Aug 25, 2021
@dsilhavy dsilhavy mentioned this issue Aug 27, 2021
@dsilhavy
Copy link
Collaborator

Fixed in #3745

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants