Unused function _abortBeforeAppend in SourceBufferSink

[lkinasiewicz]

Environment

• Dash.js version: 4.4.1

Function _abortBeforeAppend in SourceBufferSink.js is not used. This is a function returning a promise but it is used as if it was a promise here:

dash.js/src/streaming/SourceBufferSink.js

Line 84 in 176796e

promises.push(_abortBeforeAppend);

Therefore, it is never called.

Maybe this function can be safely removed or maybe it causes some bugs that I am not aware of and the mentioned line should be replaced like this:

        const promises = [];

-       promises.push(_abortBeforeAppend);
+       promises.push(_abortBeforeAppend());
        promises.push(updateAppendWindow(mediaInfo.streamInfo));
        promises.push(changeType(codec));