Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack #3596
Webpack #3596
Changes from 18 commits
f7f3326
21ce874
8d90f18
f77bf7f
18b11da
c35a23f
ec7dae5
fef5dff
62955c8
c92b2ab
bf71393
a55249e
9d1ca66
29727cf
0d1f54e
333c428
b95d6b7
9a27bfb
f84e47c
ccb69c9
f997228
48d04b5
323de81
505db42
4088e35
520c578
5c70bfc
b1b4cc8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the condition "${CIRCLE_BRANCH}" = "development" would result in having builds from any branch deployed via ftp as circle ci builds happen on any branch. Most of those deployment would be not desired in most cases (feature branches would overwrite the "nightly build"). Only from one agreed on branch deployments should happen (currently this was/is "development").
Btw, sorry, i owe you all some docu/howto on circle ci config ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was done temporarily to check ftp push feature in this branch .
This will restore before being merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i'll keep this one open so we do not forget..
This file was deleted.